Skip to content

Commit 834d167

Browse files
lidelfsdiogo
authored andcommitted
docs: remove CORS Credentials header (#45)
Share App does not need this header. See also: - Potential problem with `Access-Control-Allow-Credentials`: ipfs/kubo#5745 - HTTP Headers Cleanup: ipfs/in-web-browsers#132
1 parent 4ca3fd4 commit 834d167

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ Or do it manually:
7373
```sh
7474
> ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin '["http://localhost:3000", "https://share.ipfs.io"]'
7575
> ipfs config --json API.HTTPHeaders.Access-Control-Allow-Methods '["PUT", "GET", "POST"]'
76-
> ipfs config --json API.HTTPHeaders.Access-Control-Allow-Credentials '["true"]'
7776
```
7877

7978
To reset the config to its default state run:

cors-config.sh

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ set -e
77

88
ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin "[$ALLOW_ORIGINS]"
99
ipfs config --json API.HTTPHeaders.Access-Control-Allow-Methods '["PUT", "GET", "POST"]'
10-
ipfs config --json API.HTTPHeaders.Access-Control-Allow-Credentials '["true"]'
1110

1211
echo "IPFS API CORS headers configured for $ALLOW_ORIGINS"
1312
echo "Please restart your IPFS daemon"

src/components/box/Box.js

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const RawBoxNotAvailable = ({ t }) => (
5252
<div className='pa3 bg-black-80 bt bw4 br2 gray-muted f7 nowrap overflow-x-scroll'>
5353
<code className='db'>$ ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin '["{ window.location.origin }", "https://share.ipfs.io"]'</code>
5454
<code className='db'>$ ipfs config --json API.HTTPHeaders.Access-Control-Allow-Methods '["PUT", "GET", "POST"]'</code>
55-
<code className='db'>$ ipfs config --json API.HTTPHeaders.Access-Control-Allow-Credentials '["true"]'</code>
5655
</div>
5756
<p className='mv3 navy f6 lh-copy'>{t('box.runDaemon')}</p>
5857
<div className='pa3 bg-black-80 bt bw4 br2 gray-muted f7 nowrap overflow-x-scroll'>

0 commit comments

Comments
 (0)