Skip to content

Commit 9eb327b

Browse files
authored
fix: remove final - from addlistener slug (#27)
1 parent a0ab0f4 commit 9eb327b

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

src/formatting.ts

+7
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,13 @@ export function formatMethodSignature(m: DocsInterfaceMethod) {
8383
return `${m.name}(${m.parameters.length > 0 ? '...' : ''})`;
8484
}
8585

86+
export function formatMethodSignatureForSlug(m: DocsInterfaceMethod) {
87+
if (m.name === 'addListener' && m.parameters.length > 0) {
88+
return `addListener(${m.parameters[0].type.replace(/\"/g, `'`)})`;
89+
}
90+
return `${m.name}(${m.parameters.length > 0 ? '...' : ''})`;
91+
}
92+
8693
function linkToken(data: DocsData, token: string) {
8794
const t = token.replace(/`/g, '');
8895
const i = data.interfaces.find(i => {

src/parse.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import type {
1515
} from './types';
1616
import { getTsProgram } from './transpile';
1717
import GithubSlugger from 'github-slugger';
18-
import { formatMethodSignature } from './formatting';
18+
import { formatMethodSignatureForSlug } from './formatting';
1919

2020
/**
2121
* Given either a tsconfig file path, or exact input files, will
@@ -325,7 +325,7 @@ function getInterfaceMethod(
325325
slug: '',
326326
};
327327

328-
m.slug = slugify(formatMethodSignature(m));
328+
m.slug = slugify(formatMethodSignatureForSlug(m));
329329

330330
return m;
331331
}

src/test/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Below is an index of all the methods available.
1111
* [`impact(...)`](#impact)
1212
* [`notification(...)`](#notification)
1313
* [`vibrate(...)`](#vibrate)
14-
* [`addListener('vibrate', ...)`](#addlistenervibrate-)
14+
* [`addListener('vibrate', ...)`](#addlistenervibrate)
1515
* [`removeAllListeners()`](#removealllisteners)
1616
* [Interfaces](#interfaces)
1717
* [Type Aliases](#type-aliases)

src/test/docs.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"complexTypes": [
111111
"VibrateListener"
112112
],
113-
"slug": "addlistenervibrate-"
113+
"slug": "addlistenervibrate"
114114
},
115115
{
116116
"name": "removeAllListeners",

src/test/parse.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ describe('parse', () => {
9090

9191
const m3 = api.methods[3];
9292
expect(m3.name).toBe(`addListener`);
93-
expect(m3.slug).toBe(`addlistenervibrate-`);
93+
expect(m3.slug).toBe(`addlistenervibrate`);
9494
expect(m3.docs).toBe(`Add a listener. Callback has VibrateOptions.`);
9595
expect(m3.signature).toBe(
9696
`(eventName: 'vibrate', listenerFunc: VibrateListener) => Promise<void>`,

0 commit comments

Comments
 (0)