Skip to content

Commit 4f37bfc

Browse files
committed
fix(cli): do not raise error for unknown platforms in config
fixes #52
1 parent 2d6eae6 commit 4f37bfc

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/cli.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import et from 'elementtree';
33
import { Options, PlatformOptions } from '.';
44
import { getPlatforms } from './config';
55
import { BadInputError } from './error';
6-
import { AdaptiveIconResourceOptions, Platform, RunPlatformOptions, SimpleResourceOptions, validatePlatforms } from './platform';
6+
import { AdaptiveIconResourceOptions, Platform, RunPlatformOptions, SimpleResourceOptions, filterSupportedPlatforms, validatePlatforms } from './platform';
77
import { DEFAULT_RESOURCES_DIRECTORY, RESOURCE_TYPES, ResourceKey, ResourceType, Source, SourceType, validateResourceTypes } from './resources';
88
import { getOptionValue } from './utils/cli';
99

@@ -13,7 +13,7 @@ export function getDirectory(): string {
1313

1414
export async function resolveOptions(args: ReadonlyArray<string>, directory: string, config?: et.ElementTree): Promise<Options> {
1515
const doc = config ? config.getroot() : undefined;
16-
const platformList = validatePlatforms(doc ? getPlatforms(doc) : []);
16+
const platformList = filterSupportedPlatforms(doc ? getPlatforms(doc) : []);
1717
const parsedOptions = parseOptions(args);
1818
const { resourcesDirectory = DEFAULT_RESOURCES_DIRECTORY } = parsedOptions;
1919

src/platform.ts

+4
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,10 @@ export function validatePlatforms(platforms: ReadonlyArray<string>): Platform[]
330330
return result;
331331
}
332332

333+
export function filterSupportedPlatforms(platforms: ReadonlyArray<string>): Platform[] {
334+
return platforms.filter(isSupportedPlatform);
335+
}
336+
333337
export function isSupportedPlatform(platform: any): platform is Platform {
334338
return PLATFORMS.includes(platform);
335339
}

0 commit comments

Comments
 (0)