Skip to content

Commit 931a93b

Browse files
igchormartygrant
andauthored
Bump UR and adjust use of urKernelSuggestMaxCooperativeGroupCountExp (#15966)
Ref: oneapi-src/unified-runtime#2277 --------- Co-authored-by: Martin Morrison-Grant <[email protected]>
1 parent 2444c91 commit 931a93b

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed
+6-6
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# commit bb64b3e9f6d30b232b204590b94250ce2da6967b
2-
# Merge: d23739306f2c e625bfdaa99b
1+
# commit ea0f3a1f5f15f9af7bf40bd13669afeb9ada569c
2+
# Merge: bb64b3e9f6d3 4a89e1c69a65
33
# Author: Martin Grant <[email protected]>
4-
# Date: Martin Grant <[email protected]>
5-
# Merge pull request #2471 from Bensuo/ben/l0-include-fix
6-
# [L0] Fix issue with test include path
7-
set(UNIFIED_RUNTIME_TAG bb64b3e9f6d30b232b204590b94250ce2da6967b)
4+
# Date: Thu Dec 19 11:26:01 2024 +0000
5+
# Merge pull request #2277 from igchor/cooperative_fix
6+
# [Spec] fix urKernelSuggestMaxCooperativeGroupCountExp
7+
set(UNIFIED_RUNTIME_TAG ea0f3a1f5f15f9af7bf40bd13669afeb9ada569c)

sycl/source/detail/kernel_impl.hpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ kernel_impl::queryMaxNumWorkGroups(queue Queue,
320320
const auto &Adapter = getAdapter();
321321
const auto &Handle = getHandleRef();
322322
auto Device = Queue.get_device();
323+
auto DeviceHandleRef = sycl::detail::getSyclObjImpl(Device)->getHandleRef();
323324

324325
size_t WG[Dimensions];
325326
WG[0] = WorkGroupSize[0];
@@ -331,7 +332,8 @@ kernel_impl::queryMaxNumWorkGroups(queue Queue,
331332
uint32_t GroupCount{0};
332333
if (auto Result = Adapter->call_nocheck<
333334
UrApiKind::urKernelSuggestMaxCooperativeGroupCountExp>(
334-
Handle, Dimensions, WG, DynamicLocalMemorySize, &GroupCount);
335+
Handle, DeviceHandleRef, Dimensions, WG, DynamicLocalMemorySize,
336+
&GroupCount);
335337
Result != UR_RESULT_ERROR_UNSUPPORTED_FEATURE &&
336338
Result != UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE) {
337339
// The feature is supported and the group size is valid. Check for other

0 commit comments

Comments
 (0)