Skip to content

Commit 08373e9

Browse files
committed
fix failures
1 parent ee4c0a2 commit 08373e9

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

clang/lib/Driver/SanitizerArgs.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88
#include "clang/Driver/SanitizerArgs.h"
9+
#include "clang/Basic/DiagnosticDriver.h"
910
#include "clang/Basic/Sanitizers.h"
1011
#include "clang/Driver/Driver.h"
1112
#include "clang/Driver/Options.h"
@@ -1319,8 +1320,10 @@ void SanitizerArgs::addArgs(const ToolChain &TC, const llvm::opt::ArgList &Args,
13191320
CmdArgs.push_back("-msan-poison-stack-with-call=1");
13201321

13211322
if (MsanTrackOrigins) {
1322-
assert(MsanTrackOrigins == 1 &&
1323-
"Only support -fsanitize-memory-track-origins=1");
1323+
// FIXME: Support enhanced origins tracking in device offloading.
1324+
if (MsanTrackOrigins != 1)
1325+
TC.getDriver().Diag(diag::err_drv_argument_only_allowed_with)
1326+
<< "-fsanitize-memory-track-origins=1";
13241327
CmdArgs.push_back("-mllvm");
13251328
CmdArgs.push_back(Args.MakeArgString("-msan-track-origins=" +
13261329
Twine(MsanTrackOrigins)));

clang/test/Driver/sycl-device-sanitizer.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@
4949
// SYCL-MSAN-SAME: "-mllvm" "-msan-eager-checks=1"
5050

5151
// RUN: %clangxx -fsycl -fsanitize=memory -fsanitize-memory-track-origins=1 -c %s -### 2>&1 \
52-
// RUN: | FileCheck --check-prefix=SYCL-MSAN %s
53-
// SYCL-MSAN: clang{{.*}} "-fsycl-is-device"
54-
// SYCL-MSAN-SAME: -fsanitize=memory
55-
// SYCL-MSAN-SAME: "-mllvm" "-msan-track-origins=1"
52+
// RUN: | FileCheck --check-prefix=SYCL-MSAN-ORIGIN %s
53+
// SYCL-MSAN-ORIGIN: clang{{.*}} "-fsycl-is-device"
54+
// SYCL-MSAN-ORIGIN-SAME: -fsanitize=memory
55+
// SYCL-MSAN-ORIGIN-SAME: "-mllvm" "-msan-track-origins=1"
5656

5757
// RUN: %clangxx -fsycl -Xarch_device -fsanitize=memory -c %s -### 2>&1 \
5858
// RUN: | FileCheck --check-prefix=SYCL-MSAN-XARCH-DEVICE %s

0 commit comments

Comments
 (0)