Merge pull request #1643 from eliaskoromilas/main

mythi · web-flow · commit e673ca922197 · 2024-01-12T06:56:15.000+02:00
FPGA: Drop OpenCL UUID bitstream validation
diff --git a/pkg/fpga/bitstream/aocx.go b/pkg/fpga/bitstream/aocx.go
@@ -172,10 +172,11 @@ func parseFpgaBin(d []byte) (*FileGBS, error) {
 		return nil, err
 	}
 
-	if afuUUID := g.AcceleratorTypeUUID(); afuUUID != OpenCLUUID {
-		g.Close()
-		return nil, errors.Errorf("incorrect OpenCL BSP AFU UUID (%s)", afuUUID)
-	}
+	// TODO: update OpenCLUUIDs and check against them
+	// if afuUUID := g.AcceleratorTypeUUID(); afuUUID != OpenCLUUID {
+	// 	g.Close()
+	// 	return nil, errors.Errorf("incorrect OpenCL BSP AFU UUID (%s)", afuUUID)
+	// }
 
 	return g, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -172,10 +172,11 @@ func parseFpgaBin(d []byte) (*FileGBS, error) {`
`172`	`172`	`return nil, err`
`173`	`173`	`}`
`174`	`174`
`175`		`- if afuUUID := g.AcceleratorTypeUUID(); afuUUID != OpenCLUUID {`
`176`		`- g.Close()`
`177`		`- return nil, errors.Errorf("incorrect OpenCL BSP AFU UUID (%s)", afuUUID)`
`178`		`- }`
	`175`	`+ // TODO: update OpenCLUUIDs and check against them`
	`176`	`+ // if afuUUID := g.AcceleratorTypeUUID(); afuUUID != OpenCLUUID {`
	`177`	`+ // g.Close()`
	`178`	`+ // return nil, errors.Errorf("incorrect OpenCL BSP AFU UUID (%s)", afuUUID)`
	`179`	`+ // }`
`179`	`180`
`180`	`181`	`return g, nil`
`181`	`182`	`}`