fix: test_update_flags and pdf encoding error (#2557)

* fix: test_update_flags KeyError

* fix: pdf encoding error

Author: terriko

cve_bin_tool/output_engine/__init__.py

@@ -783,11 +783,12 @@ def output_file(self, output_type="console"):
         self.logger.info(f"{output_type.upper()} report stored at {self.filename}")
 
         # call to output_cves
-        mode = "w"
         if output_type == "pdf":
-            mode = "wb"
-        with open(self.filename, mode, encoding="utf8") as f:
-            self.output_cves(f, output_type)
+            with open(self.filename, "wb") as f:
+                self.output_cves(f, output_type)
+        else:
+            with open(self.filename, "w", encoding="utf8") as f:
+                self.output_cves(f, output_type)
 
     def check_file_path(self, filepath: str, output_type: str, prefix: str = "output"):
         # check if the file already exists

test/test_cli.py

@@ -178,7 +178,7 @@ def test_update_flags(self):
         )
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "-u", "whatever", "-n", "json", self.tempdir])
-        assert e.value.args[0] == ERROR_CODES[SystemExit]
+        assert e.value.args[0] == 2
 
     @staticmethod
     def check_exclude_log(caplog, exclude_path, checkers):