Skip to content

Commit fc0f0a0

Browse files
Geliang Tangintel-lab-lkp
authored andcommitted
Squash to "selftests/bpf: Add mptcp subflow subtest"
Drop ss_search() from run_subflow(). Now ss_search() are only used by bpf_sched tests. It will be dropped in next step. Signed-off-by: Geliang Tang <[email protected]>
1 parent d11a08b commit fc0f0a0

File tree

1 file changed

+10
-28
lines changed
  • tools/testing/selftests/bpf/prog_tests

1 file changed

+10
-28
lines changed

tools/testing/selftests/bpf/prog_tests/mptcp.c

Lines changed: 10 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -368,22 +368,9 @@ static int endpoint_init(char *flags)
368368
return -1;
369369
}
370370

371-
static int _ss_search(char *src, char *dst, char *port, char *keyword)
371+
static void run_subflow(void)
372372
{
373-
return SYS_NOFAIL("ip netns exec %s ss -enita src %s dst %s %s %d | grep -q '%s'",
374-
NS_TEST, src, dst, port, PORT_1, keyword);
375-
}
376-
377-
static int ss_search(char *src, char *keyword)
378-
{
379-
return _ss_search(src, ADDR_1, "dport", keyword);
380-
}
381-
382-
static void run_subflow(char *new)
383-
{
384-
int server_fd, client_fd, err;
385-
char cc[TCP_CA_NAME_MAX];
386-
socklen_t len;
373+
int server_fd, client_fd;
387374

388375
server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0);
389376
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
@@ -393,19 +380,8 @@ static void run_subflow(char *new)
393380
if (!ASSERT_GE(client_fd, 0, "connect to fd"))
394381
goto close_server;
395382

396-
len = sizeof(cc);
397-
err = getsockopt(server_fd, SOL_TCP, TCP_CONGESTION, cc, &len);
398-
if (!ASSERT_OK(err, "getsockopt(server_fd, TCP_CONGESTION)"))
399-
goto close_client;
400-
401383
send_byte(client_fd);
402384

403-
ASSERT_OK(ss_search(ADDR_1, "fwmark:0x1"), "ss_search fwmark:0x1");
404-
ASSERT_OK(ss_search(ADDR_2, "fwmark:0x2"), "ss_search fwmark:0x2");
405-
ASSERT_OK(ss_search(ADDR_1, new), "ss_search new cc");
406-
ASSERT_OK(ss_search(ADDR_2, cc), "ss_search default cc");
407-
408-
close_client:
409385
close(client_fd);
410386
close_server:
411387
close(server_fd);
@@ -441,7 +417,7 @@ static void test_subflow(void)
441417
if (endpoint_init("subflow") < 0)
442418
goto close_netns;
443419

444-
run_subflow(skel->data->cc);
420+
run_subflow();
445421

446422
close_netns:
447423
cleanup_netns(nstoken);
@@ -470,9 +446,15 @@ static struct nstoken *sched_init(char *flags, char *sched)
470446
return NULL;
471447
}
472448

449+
static int ss_search(char *src, char *dst, char *port, char *keyword)
450+
{
451+
return SYS_NOFAIL("ip netns exec %s ss -enita src %s dst %s %s %d | grep -q '%s'",
452+
NS_TEST, src, dst, port, PORT_1, keyword);
453+
}
454+
473455
static int has_bytes_sent(char *dst)
474456
{
475-
return _ss_search(ADDR_1, dst, "sport", "bytes_sent:");
457+
return ss_search(ADDR_1, dst, "sport", "bytes_sent:");
476458
}
477459

478460
static void send_data_and_verify(char *sched, bool addr1, bool addr2)

0 commit comments

Comments
 (0)