Skip to content

Commit 013dd62

Browse files
Geliang Tangintel-lab-lkp
authored andcommitted
Squash to "selftests/bpf: Add mptcp subflow subtest"
Close client_fd as Martin suggested. Please update my email address of this patch squashed to as: From: Geliang Tang <[email protected]> since BPF CI complained about it: WARNING: From:/Signed-off-by: email address mismatch: 'From: Geliang Tang <[email protected]>' != 'Signed-off-by: Geliang Tang <[email protected]>' Signed-off-by: Geliang Tang <[email protected]>
1 parent c65deb8 commit 013dd62

File tree

1 file changed

+7
-5
lines changed
  • tools/testing/selftests/bpf/prog_tests

1 file changed

+7
-5
lines changed

tools/testing/selftests/bpf/prog_tests/mptcp.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -383,19 +383,20 @@ static void run_subflow(char *new)
383383
{
384384
int server_fd, client_fd, err;
385385
char cc[TCP_CA_NAME_MAX];
386-
socklen_t len = sizeof(cc);
386+
socklen_t len;
387387

388388
server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0);
389389
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
390390
return;
391391

392392
client_fd = connect_to_fd(server_fd, 0);
393393
if (!ASSERT_GE(client_fd, 0, "connect to fd"))
394-
goto fail;
394+
goto close_server;
395395

396+
len = sizeof(cc);
396397
err = getsockopt(server_fd, SOL_TCP, TCP_CONGESTION, cc, &len);
397-
if (!ASSERT_OK(err, "getsockopt(srv_fd, TCP_CONGESTION)"))
398-
goto fail;
398+
if (!ASSERT_OK(err, "getsockopt(server_fd, TCP_CONGESTION)"))
399+
goto close_client;
399400

400401
send_byte(client_fd);
401402

@@ -404,8 +405,9 @@ static void run_subflow(char *new)
404405
ASSERT_OK(ss_search(ADDR_1, new), "ss_search new cc");
405406
ASSERT_OK(ss_search(ADDR_2, cc), "ss_search default cc");
406407

408+
close_client:
407409
close(client_fd);
408-
fail:
410+
close_server:
409411
close(server_fd);
410412
}
411413

0 commit comments

Comments
 (0)