pre-release updates

Author: ddsjoberg

.gitignore

@@ -16,5 +16,5 @@ temp/
 tests/testthat/_snaps/**/*.new.md
 tests/testthat/_snaps/**/*.new.svg
 
-# reverse dep cehcks
+# reverse dep checks
 checked/

DESCRIPTION

@@ -20,7 +20,7 @@ BugReports: https://github.com/insightsengineering/cardx/issues
 Depends:
     R (>= 4.2)
 Imports:
-    cards (>= 0.6.0.9011),
+    cards (>= 0.6.1),
     cli (>= 3.6.1),
     dplyr (>= 1.1.2),
     glue (>= 1.6.2),
@@ -44,8 +44,6 @@ Suggests:
     survival (>= 3.6-4),
     testthat (>= 3.2.0),
     withr (>= 2.5.0)
-Remotes: 
-    insightsengineering/cards
 Config/Needs/website: insightsengineering/nesttemplate
 Config/testthat/edition: 3
 Config/testthat/parallel: true

NEWS.md

@@ -1,15 +1,15 @@
 # cardx 0.2.4.9008
 
+* Adding `strata` argument to `ard_categorical_max()`. (#445, @jtalboys)
+
+* Added function `ard_incidence_rate()` to calculate ARDs for incidence rate estimation. (#234)
+
 * Updating any `fmt_fn` references to `fmt_fun` for consistency. 
 
     * Any function with an argument `cardx::foo(fmt_fn)` has been updated to `cardx::foo(fmt_fun)`. The old syntax will continue to function, but with a deprecation warning to users.
 
     * Importantly, the ARD column named `"fmt_fn"` has been updated to `"fmt_fun"`. This change cannot be formally deprecated. For users who were accessing the ARD object directly to modify this column instead of using functions like `cards::update_ard_fmt_fun()`, this will be a breaking change.
 
-* Adding `strata` argument to `ard_categorical_max()`. (#445, @jtalboys)
-
-* Added function `ard_incidence_rate()` to calculate ARDs for incidence rate estimation. (#234)
-
 * Fix in `ard_survival_survfit.data.frame()` method where the stratifying variable was not correctly converted back to its original type.
 
 * Fix in `ard_total_n.survey.design()` to use `update()` instead of `dplyr::mutate()`, which sometimes caused a downstream issue.

README.md

@@ -77,7 +77,7 @@ cards::ADSL |>
     ## 13    ARM      AGE stats_t_…   var.equal  Equal Va…     FALSE
     ## 14    ARM      AGE stats_t_…  conf.level  CI Confi…      0.95
 
-    ## ℹ 3 more variables: fmt_fn, warning, error
+    ## ℹ 3 more variables: fmt_fun, warning, error
 
 Note that the returned ARD contains the analysis results in addition to
 the function parameters used to calculate the results allowing for
@@ -108,13 +108,13 @@ construct_model(
 
     ## {cards} data frame: 6 x 8
 
-    ##      variable   context stat_name stat_label     stat fmt_fn
-    ## 1 (Intercept) aod_wald…        df  Degrees …        1      1
-    ## 2 (Intercept) aod_wald… statistic  Statistic 7126.713      1
-    ## 3 (Intercept) aod_wald…   p.value    p-value        0      1
-    ## 4         ARM aod_wald…        df  Degrees …        2      1
-    ## 5         ARM aod_wald… statistic  Statistic    1.046      1
-    ## 6         ARM aod_wald…   p.value    p-value    0.593      1
+    ##      variable   context stat_name stat_label     stat fmt_fun
+    ## 1 (Intercept) aod_wald…        df  Degrees …        1       1
+    ## 2 (Intercept) aod_wald… statistic  Statistic 7126.713       1
+    ## 3 (Intercept) aod_wald…   p.value    p-value        0       1
+    ## 4         ARM aod_wald…        df  Degrees …        2       1
+    ## 5         ARM aod_wald… statistic  Statistic    1.046       1
+    ## 6         ARM aod_wald…   p.value    p-value    0.593       1
 
     ## ℹ 2 more variables: warning, error
 

cran-comments.md

@@ -10,9 +10,11 @@
 
 ## revdepcheck results
 
-We checked 4 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 6 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
  * We saw 1 new problem in the 'gtsummary' package. I maintain this package and the break is expected. I will submit a new version as soon as 'cardx' is on CRAN.
+ 
+ * We failed to check 0 packages
 
 ## Additional Comments
 

revdep/README.md

@@ -1,38 +1,51 @@
 # Platform
 
-|field    |value                                      |
-|:--------|:------------------------------------------|
-|version  |R version 4.4.2 (2024-10-31)               |
-|os       |macOS Ventura 13.6.9                       |
-|system   |aarch64, darwin20                          |
-|ui       |RStudio                                    |
-|language |(EN)                                       |
-|collate  |en_US.UTF-8                                |
-|ctype    |en_US.UTF-8                                |
-|tz       |America/Los_Angeles                        |
-|date     |2025-02-17                                 |
-|rstudio  |2024.12.0+467.pro1 Kousa Dogwood (desktop) |
-|pandoc   |3.4 @ /usr/local/bin/pandoc                |
+|field    |value                                        |
+|:--------|:--------------------------------------------|
+|version  |R version 4.5.0 (2025-04-11)                 |
+|os       |macOS Ventura 13.6.9                         |
+|system   |aarch64, darwin20                            |
+|ui       |RStudio                                      |
+|language |(EN)                                         |
+|collate  |en_US.UTF-8                                  |
+|ctype    |en_US.UTF-8                                  |
+|tz       |America/Los_Angeles                          |
+|date     |2025-07-03                                   |
+|rstudio  |2025.05.0+496.pro5 Mariposa Orchid (desktop) |
+|pandoc   |3.4 @ /usr/local/bin/pandoc                  |
 
 # Dependencies
 
-|package    |old   |new        |Δ  |
-|:----------|:-----|:----------|:--|
-|cardx      |0.2.2 |0.2.2.9023 |*  |
-|cards      |0.4.0 |0.5.0.9000 |*  |
-|cli        |NA    |3.6.4      |*  |
-|cpp11      |NA    |0.5.1      |*  |
-|fansi      |NA    |1.0.6      |*  |
-|glue       |NA    |1.8.0      |*  |
-|pillar     |NA    |1.10.1     |*  |
-|purrr      |NA    |1.0.4      |*  |
-|R6         |NA    |2.6.1      |*  |
-|rlang      |NA    |1.1.5      |*  |
-|stringi    |NA    |1.8.4      |*  |
-|tidyr      |NA    |1.3.1      |*  |
-|tidyselect |NA    |1.2.1      |*  |
-|vctrs      |NA    |0.6.5      |*  |
-|withr      |NA    |3.0.2      |*  |
+|package    |old    |new        |Δ  |
+|:----------|:------|:----------|:--|
+|cardx      |0.2.4  |0.2.4.9008 |*  |
+|cards      |0.6.0  |0.6.1.9000 |*  |
+|cli        |3.6.5  |3.6.5      |   |
+|cpp11      |0.5.2  |0.5.2      |   |
+|dplyr      |1.1.4  |1.1.4      |   |
+|generics   |0.1.4  |0.1.4      |   |
+|glue       |1.8.0  |1.8.0      |   |
+|lifecycle  |1.0.4  |1.0.4      |   |
+|magrittr   |2.0.3  |2.0.3      |   |
+|pillar     |1.10.2 |1.10.2     |   |
+|pkgconfig  |2.0.3  |2.0.3      |   |
+|purrr      |1.0.4  |1.0.4      |   |
+|R6         |2.6.1  |2.6.1      |   |
+|rlang      |1.1.6  |1.1.6      |   |
+|stringi    |1.8.7  |1.8.7      |   |
+|stringr    |1.5.1  |1.5.1      |   |
+|tibble     |3.3.0  |3.3.0      |   |
+|tidyr      |1.3.1  |1.3.1      |   |
+|tidyselect |1.2.1  |1.2.1      |   |
+|utf8       |1.2.6  |1.2.6      |   |
+|vctrs      |0.6.5  |0.6.5      |   |
+|withr      |3.0.2  |3.0.2      |   |
 
 # Revdeps
 
+## New problems (1)
+
+|package   |version |error  |warning |note |
+|:---------|:-------|:------|:-------|:----|
+|[gtsummary](problems.md#gtsummary)|2.2.0   |__+2__ |        |     |
+

revdep/cran.md

@@ -1,7 +1,16 @@
 ## revdepcheck results
 
-We checked 4 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 6 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 0 new problems
+ * We saw 1 new problems
  * We failed to check 0 packages
 
+Issues with CRAN packages are summarised below.
+
+### New problems
+(This reports the first line of each new failure)
+
+* gtsummary
+  checking examples ... ERROR
+  checking tests ...
+

revdep/problems.md

@@ -1 +1,66 @@
-*Wow, no problems at all. :)*
+# gtsummary
+
+<details>
+
+* Version: 2.2.0
+* GitHub: https://github.com/ddsjoberg/gtsummary
+* Source code: https://github.com/cran/gtsummary
+* Date/Publication: 2025-04-14 10:30:02 UTC
+* Number of recursive dependencies: 204
+
+Run `revdepcheck::revdep_details(, "gtsummary")` for more info
+
+</details>
+
+## Newly broken
+
+*   checking examples ... ERROR
+    ```
+    Running examples in ‘gtsummary-Ex.R’ failed
+    The error most likely occurred in:
+    
+    > ### Name: add_ci
+    > ### Title: Add CI Column
+    > ### Aliases: add_ci add_ci.tbl_summary
+    > 
+    > ### ** Examples
+    > 
+    > ## Don't show: 
+    ...
+     29. │               └─dplyr:::mutate_col(dots[[i]], data, mask, new_columns)
+     30. │                 └─mask$eval_all_mutate(quo)
+     31. │                   └─dplyr (local) eval()
+     32. ├─base::ifelse(...)
+     33. ├─fmt_fn
+     34. ├─rlang:::`$.rlang_data_pronoun`(.data, fmt_fn)
+     35. │ └─rlang:::data_pronoun_get(...)
+     36. └─rlang:::abort_data_pronoun(x, call = y)
+     37.   └─rlang::abort(msg, "rlang_error_data_pronoun_not_found", call = call)
+    Execution halted
+    ```
+
+*   checking tests ...
+    ```
+      Running ‘spelling.R’
+      Comparing ‘spelling.Rout’ to ‘spelling.Rout.save’ ... OK
+      Running ‘testthat.R’
+     ERROR
+    Running the tests in ‘tests/testthat.R’ failed.
+    Last 13 lines of output:
+      + Condition
+      +   Warning:
+      +   The `fmt_fn` argument of `ard_categorical()` is deprecated as of cards 0.6.1.
+      +   i Please use the `fmt_fun` argument instead.
+    ...
+      +   The `fmt_fn` argument of `ard_dichotomous()` is deprecated as of cards 0.6.1.
+      +   i Please use the `fmt_fun` argument instead.
+      and 15 more ...
+      
+      * Run `testthat::snapshot_accept('theme_gtsummary')` to accept the change.
+      * Run `testthat::snapshot_review('theme_gtsummary')` to interactively review the change.
+      
+      [ FAIL 233 | WARN 2367 | SKIP 0 | PASS 1361 ]
+      Error: Test failures
+      Execution halted
+    ```
+