Skip to content

Commit ffdf528

Browse files
ATL-6668: Delete legacy operation related to credentials
This commit deletes the IssueCredentialBatchOperation and RevokeCredentialsOperation. It does not delete node API, daos nor repositories related to credentials
1 parent 25d1fae commit ffdf528

21 files changed

+14
-2591
lines changed

node/src/main/scala/io/iohk/atala/prism/node/NodeExplorerGrpcServiceImpl.scala

-6
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ import io.iohk.atala.prism.protos.node_api
1919
import io.iohk.atala.prism.protos.node_api.GetScheduledOperationsRequest.OperationType.{
2020
AnyOperationType,
2121
CreateDidOperationOperationType,
22-
IssueCredentialBatchOperationType,
2322
ProtocolVersionUpdateOperationType,
24-
RevokeCredentialsOperationType,
2523
UpdateDidOperationOperationType
2624
}
2725
import io.iohk.atala.prism.protos.node_api._
@@ -102,10 +100,6 @@ class NodeExplorerGrpcServiceImpl(
102100
o.operation.isDefined && o.operation.get.operation.isCreateDid
103101
case UpdateDidOperationOperationType =>
104102
o.operation.isDefined && o.operation.get.operation.isUpdateDid
105-
case IssueCredentialBatchOperationType =>
106-
o.operation.isDefined && o.operation.get.operation.isIssueCredentialBatch
107-
case RevokeCredentialsOperationType =>
108-
o.operation.isDefined && o.operation.get.operation.isRevokeCredentials
109103
case ProtocolVersionUpdateOperationType =>
110104
o.operation.isDefined && o.operation.get.operation.isProtocolVersionUpdate
111105
case _ => false

node/src/main/scala/io/iohk/atala/prism/node/metrics/StatisticsCounters.scala

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ object StatisticsCounters {
1212

1313
case object NumberOfPendingOperations extends MetricCounter
1414
case object NumberOfPublishedDids extends MetricCounter
15-
case object NumberOfIssuedCredentialBatches extends MetricCounter
16-
case object NumberOfCredentialsRevoked extends MetricCounter
1715
case object NumberOfAppliedTransactions extends MetricCounter
1816
case object NumberOfRejectedTransactions extends MetricCounter
1917
}

node/src/main/scala/io/iohk/atala/prism/node/operations/IssueCredentialBatchOperation.scala

-130
This file was deleted.

node/src/main/scala/io/iohk/atala/prism/node/operations/RevokeCredentialsOperation.scala

-153
This file was deleted.

node/src/main/scala/io/iohk/atala/prism/node/operations/package.scala

+8-4
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,6 @@ package object operations {
320320
CreateDIDOperation.parse(signedOperation, ledgerData)
321321
case _: node_models.AtalaOperation.Operation.UpdateDid =>
322322
UpdateDIDOperation.parse(signedOperation, ledgerData)
323-
case _: node_models.AtalaOperation.Operation.IssueCredentialBatch =>
324-
IssueCredentialBatchOperation.parse(signedOperation, ledgerData)
325-
case _: node_models.AtalaOperation.Operation.RevokeCredentials =>
326-
RevokeCredentialsOperation.parse(signedOperation, ledgerData)
327323
case _: node_models.AtalaOperation.Operation.ProtocolVersionUpdate =>
328324
ProtocolVersionUpdateOperation.parse(signedOperation, ledgerData)
329325
case _: node_models.AtalaOperation.Operation.DeactivateDid =>
@@ -336,6 +332,14 @@ package object operations {
336332
"Empty operation"
337333
)
338334
)
335+
case op => // we need to discard unrecognized operations
336+
Left(
337+
InvalidValue(
338+
Path.root,
339+
op.getClass.getSimpleName,
340+
s"Unsupported ${op.getClass.getSimpleName}"
341+
)
342+
)
339343
}
340344
}
341345

node/src/main/scala/io/iohk/atala/prism/node/operations/protocolVersion.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ package object protocolVersion {
2727
(protocolV, operation) match {
2828
case (
2929
ProtocolVersion1_0,
30-
_: CreateDIDOperation | _: UpdateDIDOperation | _: IssueCredentialBatchOperation |
31-
_: RevokeCredentialsOperation | _: ProtocolVersionUpdateOperation | _: DeactivateDIDOperation
30+
_: CreateDIDOperation | _: UpdateDIDOperation |
31+
_: ProtocolVersionUpdateOperation | _: DeactivateDIDOperation
3232
) =>
3333
true
3434
case _ => false

node/src/main/scala/io/iohk/atala/prism/node/services/StatisticsService.scala

+1-11
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,12 @@ import io.iohk.atala.prism.node.errors
1010
import io.iohk.atala.prism.node.metrics.StatisticsCounters
1111
import io.iohk.atala.prism.node.metrics.StatisticsCounters.MetricCounter.{
1212
NumberOfAppliedTransactions,
13-
NumberOfCredentialsRevoked,
14-
NumberOfIssuedCredentialBatches,
1513
NumberOfPendingOperations,
1614
NumberOfPublishedDids,
1715
NumberOfRejectedTransactions
1816
}
1917
import io.iohk.atala.prism.node.models.AtalaOperationStatus
20-
import io.iohk.atala.prism.node.operations.{
21-
CreateDIDOperation,
22-
IssueCredentialBatchOperation,
23-
RevokeCredentialsOperation
24-
}
18+
import io.iohk.atala.prism.node.operations.CreateDIDOperation
2519
import io.iohk.atala.prism.node.repositories.{AtalaOperationsRepository, MetricsCountersRepository}
2620
import io.iohk.atala.prism.node.services.logs.StatisticsServiceLogs
2721
import tofu.higherKind.Mid
@@ -53,10 +47,6 @@ private final class StatisticsServiceImpl[F[_]: Applicative](
5347
getAtalaOperationsCountByStatus(AtalaOperationStatus.RECEIVED)
5448
case NumberOfPublishedDids =>
5549
metricsCountersRepository.getCounter(CreateDIDOperation.metricCounterName).map(Right(_))
56-
case NumberOfIssuedCredentialBatches =>
57-
metricsCountersRepository.getCounter(IssueCredentialBatchOperation.metricCounterName).map(Right(_))
58-
case NumberOfCredentialsRevoked =>
59-
metricsCountersRepository.getCounter(RevokeCredentialsOperation.metricCounterName).map(Right(_))
6050
case NumberOfAppliedTransactions =>
6151
getAtalaOperationsCountByStatus(AtalaOperationStatus.APPLIED)
6252
case NumberOfRejectedTransactions =>

0 commit comments

Comments
 (0)