fix(GmsCore support): Patched apps are not added to Cloud Messaging inotia00/ReVanced_Extended#2691

Author: inotia00

extensions/shared/src/main/java/app/revanced/extension/shared/patches/spoof/SpoofStreamingDataPatch.java

@@ -109,16 +109,6 @@ public static boolean isSpoofingEnabled() {
         return SPOOF_STREAMING_DATA;
     }
 
-    /**
-     * Injection point.
-     */
-    public static Object isSpoofingEnabled(Object original) {
-        if (!SPOOF_STREAMING_DATA) {
-            return original;
-        }
-        return null;
-    }
-
     /**
      * Injection point.
      * This method is only invoked when playing a livestream on an iOS client.

patches/src/main/kotlin/app/revanced/patches/shared/spoof/streamingdata/BaseSpoofStreamingDataPatch.kt

@@ -14,14 +14,11 @@ import app.revanced.patcher.util.proxy.mutableTypes.MutableMethod.Companion.toMu
 import app.revanced.patches.shared.extension.Constants.SPOOF_PATH
 import app.revanced.patches.shared.formatStreamModelConstructorFingerprint
 import app.revanced.util.findInstructionIndicesReversedOrThrow
-import app.revanced.util.findMethodOrThrow
 import app.revanced.util.fingerprint.definingClassOrThrow
 import app.revanced.util.fingerprint.injectLiteralInstructionBooleanCall
 import app.revanced.util.fingerprint.matchOrThrow
 import app.revanced.util.fingerprint.methodOrThrow
-import app.revanced.util.fingerprint.mutableClassOrThrow
 import app.revanced.util.getReference
-import app.revanced.util.getWalkerMethod
 import app.revanced.util.indexOfFirstInstructionOrThrow
 import com.android.tools.smali.dexlib2.AccessFlags
 import com.android.tools.smali.dexlib2.Opcode
@@ -370,35 +367,4 @@ fun baseSpoofStreamingDataPatch(
         executeBlock()
 
     }
-
-    finalize {
-        gmsServiceBrokerFingerprint.methodOrThrow()
-            .addInstructionsWithLabels(
-                0, """
-                    invoke-static {}, $EXTENSION_CLASS_DESCRIPTOR->isSpoofingEnabled()Z
-                    move-result v0
-                    if-eqz v0, :ignore
-                    return-void
-                    :ignore
-                    nop
-                    """
-            )
-
-        gmsServiceBrokerExceptionFingerprint.matchOrThrow().let {
-            val walkerIndex = it.patternMatch!!.startIndex
-            val walkerMethod = it.getWalkerMethod(walkerIndex)
-
-            walkerMethod.apply {
-                val insertIndex = indexOfFirstInstructionOrThrow(Opcode.CHECK_CAST)
-                val insertRegister = getInstruction<OneRegisterInstruction>(insertIndex).registerA
-
-                addInstructions(
-                    insertIndex + 1, """
-                        invoke-static {v$insertRegister}, $EXTENSION_CLASS_DESCRIPTOR->isSpoofingEnabled(Ljava/lang/Object;)Ljava/lang/Object;
-                        move-result-object v$insertRegister
-                        """
-                )
-            }
-        }
-    }
 }

patches/src/main/kotlin/app/revanced/patches/shared/spoof/streamingdata/Fingerprints.kt

@@ -198,20 +198,4 @@ internal val hlsCurrentTimeFingerprint = legacyFingerprint(
     literals = listOf(HLS_CURRENT_TIME_FEATURE_FLAG),
 )
 
-internal val gmsServiceBrokerFingerprint = legacyFingerprint(
-    name = "gmsServiceBrokerFingerprint",
-    returnType = "V",
-    strings = listOf("mServiceBroker is null, client disconnected")
-)
-
-internal val gmsServiceBrokerExceptionFingerprint = legacyFingerprint(
-    name = "gmsServiceBrokerExceptionFingerprint",
-    returnType = "V",
-    parameters = listOf("Ljava/lang/Exception;"),
-    opcodes = listOf(
-        Opcode.INVOKE_VIRTUAL,
-        Opcode.RETURN_VOID
-    ),
-    strings = listOf("Exception must not be null")
-)