Skip to content

bug: Reddit 2025.06 - Disable screenshot popup, Hide navigation buttons, Remove subreddit dialog Patch failed #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
30b0 opened this issue Feb 8, 2025 · 14 comments
Labels
Bug report Something isn't working

Comments

@30b0
Copy link

30b0 commented Feb 8, 2025

Type

Error while patching

Tools used

RVX Manager

Application

Reddit 2025.06.0
Patches v.5.4.1-dev.4

Bug description

  • Disable Screenshot Popup
  • Hide Navigation Buttons
  • Remove Subreddit Dialog

These Patches failed while Patching the newest Version 2025.06.0 with the RVX Manager.

Error logs

Disable screenshot popup failed: app.revanced.patcher.patch.PatchException: Failed to resolve screenshotTakenBannerFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.screenshotpopup.ScreenshotPopupPatchKt.screenshotPopupPatch$lambda$2$lambda$1(ScreenshotPopupPatch.kt:27)
	at app.revanced.patches.reddit.layout.screenshotpopup.ScreenshotPopupPatchKt.$r8$lambda$6P66SX-KqraKsnPfsrzQecQoVj0(Unknown Source:0)
	at app.revanced.patches.reddit.layout.screenshotpopup.ScreenshotPopupPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1117)


Hide navigation buttons failed: app.revanced.patcher.patch.PatchException: Failed to resolve bottomNavScreenSetupBottomNavigationFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.navigation.NavigationButtonsPatchKt.navigationButtonsPatch$lambda$7$lambda$6(NavigationButtonsPatch.kt:37)
	at app.revanced.patches.reddit.layout.navigation.NavigationButtonsPatchKt.$r8$lambda$FyMiZ9EYq1fmgi4pf8HeyBXI3Zw(Unknown Source:0)
	at app.revanced.patches.reddit.layout.navigation.NavigationButtonsPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1117)


Remove subreddit dialog failed: app.revanced.patcher.patch.PatchException: Failed to resolve redditAlertDialogsFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.subRedditDialogPatch$lambda$7$lambda$6(SubRedditDialogPatch.kt:86)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.$r8$lambda$58F9r0gtWVsPXia7ypDQbvEpzEA(Unknown Source:0)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1117)

Solution

No response

Additional context

No response

Device Environment

OnePlus 9 Pro | Android 15 | CrDroid 11.1 | Magisk Root

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@30b0 30b0 added the Bug report Something isn't working label Feb 8, 2025
@johnnyw94

This comment has been minimized.

@AkshayKanathur

This comment has been minimized.

@johnnyw94

This comment has been minimized.

@inotia00
Copy link
Owner

inotia00 commented Feb 9, 2025

Reddit started obfuscating codes this year, so fingerprints that hadn't been broken for months began to break quite often.

(They seem to be refactoring the code)

Even if I fix the fingerprint for Reddit 2025.06.0, it's likely that the patch will break again within a few weeks.

For this reason, I will regulate Reddit's supported version to 2025.05.1.

Support for the new version will be discussed in a few months.

@inotia00
Copy link
Owner

inotia00 commented Mar 14, 2025

With revanced-patches-5.5.1-dev.1, you can patch Reddit 2025.06.0 ~ 2025.10.0.

Nevertheless, there is a issue with the anti-split APK of ARSCLib so the patch fails: iBotPeaches/Apktool#3806

(Anti-split tools such as ReVaned CLI, APKEditor, AntiSplit-M are based on ARSClib)

For this reason, unless the issue is fixed in ARSCLib, the supported version on Reddit is still 2025.05.1.

Reddit 2025.10.0 can be patched with a modified AntiSplit G2 + modified ReVanced Manager, but since it uses tools whose source code is not open source, it is not added to the documentation.

@dustlucas
Copy link

With revanced-patches-5.5.1-dev.1, you can patch Reddit 2025.06.0 ~ 2025.10.0.

Nevertheless, there is a issue with the anti-split APK of ARSCLib so the patch fails: iBotPeaches/Apktool#3806

(Anti-split tools such as ReVaned CLI, APKEditor, AntiSplit-M are based on ARSClib)

For this reason, unless the issue is fixed in ARSCLib, the supported version on Reddit is still 2025.05.1.

Reddit 2025.10.0 can be patched with a modified AntiSplit G2 + modified ReVanced Manager, but since it uses tools whose source code is not open source, it is not added to the documentation.

bro, I just patched 2025.10.0 with antisplit-M with no issues, did you use the latest version of the tool? the app is working fine

@30b0
Copy link
Author

30b0 commented Mar 21, 2025

Just tested again with the the Builds of 2025.10.0 on Apkmirror and all seem to work just fine again, that wasn't the case with the first Builds of 2025.10.0.

Even the un-unsupport Version 2025.11.0 works fine with all Patches.

On Version 2025.09.0 and 2025.09.1 you still get the mentioned Error:
Image

@Aryan-Chauhan
Copy link

I just unsplitted Reddit v2025.12.0 bundle using latest AntiSplit M, then I patched it using RVX Manager and it compiled successfully, and now I'm using it.

Will report if I find any broken feature inside the app.

@johnnyw94
Copy link

I just unsplitted Reddit v2025.12.0 bundle using latest AntiSplit M, then I patched it using RVX Manager and it compiled successfully, and now I'm using it.

Will report if I find any broken feature inside the app.

Disable screenshot pop-up patch not working correctly right? I'm getting the popup saying reddit detected this screenshot

@Aryan-Chauhan
Copy link

Aryan-Chauhan commented Mar 29, 2025

Working fine here.

But I'm getting ads in comments (v2025.12.0 and latest dev patches).

@johnnyw94
Copy link

Working fine here.

But I'm getting ads in comments (v2025.12.0 and latest dev patches).

Damn really? Idk why but I'm getting this pop-up below

Screenrecorder-2025-03-29-07-02-29-260.mp4

@30b0
Copy link
Author

30b0 commented Mar 29, 2025

Damn really? Idk why but I'm getting this pop-up below

The Difference is the Text above.

Default:
Image

Patch Enabled:
Image

They probably have changed the Screenshot Popup at some Point and the Patch will only delete the Text.

@johnnyw94
Copy link

Damn really? Idk why but I'm getting this pop-up below

The Difference is the Text above.

Default:
Image

Patch Enabled:
Image

They probably have changed the Screenshot Popup at some Point and the Patch will only delete the Text.

Aah got it.. even though it's not much of an issue, i just thought the patch was broken.

@inotia00
Copy link
Owner

It's a known issue: #1810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants