Skip to content

bug(YouTube - Disable haptic feedback): Disable seek haptic feedback doesn't work #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
Kuddus73 opened this issue Dec 21, 2024 · 9 comments
Closed
8 tasks done
Labels
Bug report Something isn't working

Comments

@Kuddus73
Copy link

Type

Other

Tools used

RVX Manager

Application

YouTube v19.44.39
Patches v5.1.1

Bug description

It's related to this issue: Hide seek message doesn't work. The bug of the message has been fixed but not its haptic feedback.

Screenshot_20241221_071957_YouTube
I don't think the haptic feedback is possible to see from the video but still including it:

Screen_Recording_20241221_072117_YouTube.mp4

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I did not use pre-release (dev branch).
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@Kuddus73 Kuddus73 added the Bug report Something isn't working label Dec 21, 2024
@inotia00
Copy link
Owner

It doesn't reproduce on my side

@Kuddus73
Copy link
Author

It doesn't reproduce on my side

To me it does vibrate if pressed and held down for few seconds like in the video.

@kyan5221
Copy link

I also can't disable long press haptic vibration on video player.

@inotia00
Copy link
Owner

This may be an issue that only occurs on certain Android versions

(I'm using Android 10)

Please indicate which Android version you are using

@kyan5221
Copy link

I'm using android 12 & 14.

@inotia00
Copy link
Owner

Thanks to this issue report, I found out that the vibration motor of my phone that I have been using for 5 years is dead

So I couldn't reproduce the issue

I tried to fix the bug by checking the source code, but I can't test on my device whether the bug is fixed correctly or not

@inotia00 inotia00 changed the title bug(YouTube): Disable seek haptic feedback doesn't work bug(YouTube - Disable haptic feedback): Disable seek haptic feedback doesn't work Dec 31, 2024
@kyan5221
Copy link

kyan5221 commented Jan 6, 2025

Thanks to this issue report, I found out that the vibration motor of my phone that I have been using for 5 years is dead

So I couldn't reproduce the issue

I tried to fix the bug by checking the source code, but I can't test on my device whether the bug is fixed correctly or not

YouTube v19.44.39 with patch v5.2.1-dev.3.

there is always no vibration even when I disable(deactivate) 'Disable seek haptic feedback'.
'Enable seekbar tapping' is activated now.

Screenshot_20250106_115015

Screenshot_20250106_114855

@inotia00
Copy link
Owner

inotia00 commented Jan 6, 2025

YouTube v19.44.39 with patch v5.2.1-dev.3.

there is always no vibration even when I disable(deactivate) 'Disable seek haptic feedback'. 'Enable seekbar tapping' is activated now.

Haptic feedback doesn't work on unpatched YouTube either

It seems to be an issue on Google's server side, as it doesn't work on unpatched YouTube 19.44.39 as well as unpatched YouTube 19.16.39

@inotia00
Copy link
Owner

inotia00 commented Jan 7, 2025

Fixed in revanced-patches-5.2.1

@inotia00 inotia00 closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants