feat(inputs.lvm): Add sync_percent for lvm_logical_vol (#17024)

Author: niklasf

plugins/inputs/lvm/README.md

@@ -90,7 +90,8 @@ volume (lv):
   - fields
     - size
     - data_percent
-    - meta_percent
+    - metadata_percent
+    - sync_percent
 
 ## Example Output
 

plugins/inputs/lvm/lvm.go

@@ -165,7 +165,7 @@ func (lvm *LVM) gatherVolumeGroups(acc telegraf.Accumulator) error {
 func (lvm *LVM) gatherLogicalVolumes(acc telegraf.Accumulator) error {
 	args := []string{
 		"--reportformat", "json", "--units", "b", "--nosuffix",
-		"-o", "lv_name,vg_name,lv_size,data_percent,metadata_percent",
+		"-o", "lv_name,vg_name,lv_size,data_percent,metadata_percent,sync_percent",
 	}
 	out, err := lvm.runCmd(lvm.LVSBinary, args)
 	if err != nil {
@@ -208,10 +208,20 @@ func (lvm *LVM) gatherLogicalVolumes(acc telegraf.Accumulator) error {
 				return err
 			}
 
+			// Only provided if sync in progress, default completed
+			if lv.SyncPercent == "" {
+				lv.SyncPercent = "100.0"
+			}
+			syncPercent, err := strconv.ParseFloat(lv.SyncPercent, 32)
+			if err != nil {
+				return err
+			}
+
 			fields := map[string]interface{}{
 				"size":             size,
 				"data_percent":     dataPercent,
 				"metadata_percent": metadataPercent,
+				"sync_percent":     syncPercent,
 			}
 
 			acc.AddFields("lvm_logical_vol", fields, tags)
@@ -273,6 +283,7 @@ type lvsReport struct {
 			Size            string `json:"lv_size"`
 			DataPercent     string `json:"data_percent"`
 			MetadataPercent string `json:"metadata_percent"`
+			SyncPercent     string `json:"sync_percent"`
 		} `json:"lv"`
 	} `json:"report"`
 }

plugins/inputs/lvm/lvm_test.go

@@ -58,8 +58,21 @@ func TestGather(t *testing.T) {
 		"size":             uint64(121899057152),
 		"data_percent":     0.36000001430511475,
 		"metadata_percent": 1.3300000429153442,
+		"sync_percent":     100.0,
 	}
 	acc.AssertContainsTaggedFields(t, "lvm_logical_vol", lvsFields, lvsTags)
+
+	lvsTags2 := map[string]string{
+		"name":      "lv",
+		"vol_group": "vg",
+	}
+	lvsFields2 := map[string]interface{}{
+		"size":             uint64(200000000000000),
+		"data_percent":     0.0,
+		"metadata_percent": 0.0,
+		"sync_percent":     39.4900016784668,
+	}
+	acc.AssertContainsTaggedFields(t, "lvm_logical_vol", lvsFields2, lvsTags2)
 }
 
 // Used as a helper function that mock the exec.Command call
@@ -103,7 +116,8 @@ func TestHelperProcess(_ *testing.T) {
 		"report": [
 			{
 				"lv": [
-					{"lv_name":"thinpool", "vg_name":"docker", "lv_size":"121899057152", "data_percent":"0.36", "metadata_percent":"1.33"}
+					{"lv_name":"thinpool", "vg_name":"docker", "lv_size":"121899057152", "data_percent":"0.36", "metadata_percent":"1.33", "sync_percent":""},
+					{"lv_name":"lv", "vg_name":"vg", "lv_size":"200000000000000", "data_percent":"", "metadata_percent":"", "sync_percent":"39.49"}
 				]
 			}
 		]