Merge pull request #359 from danielorbach/bugfix/WriteAPIBlocking-Flush-always-returns-non-nil-error

vlastahajek · web-flow · commit f6f677f6e0dc · 2022-10-25T13:35:06.000+02:00
fix(WriteAPIBlocking): properly return error from flush()
diff --git a/api/writeAPIBlocking.go b/api/writeAPIBlocking.go
@@ -119,7 +119,9 @@ func (w *writeAPIBlocking) flush(ctx context.Context) error {
 		body := strings.Join(w.batch, "\n")
 		w.batch = w.batch[:0]
 		b := iwrite.NewBatch(body, w.writeOptions.MaxRetryTime())
-		return w.service.WriteBatch(ctx, b)
+		if err:= w.service.WriteBatch(ctx, b); err != nil {
+			return err
+		}
 	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,9 @@ func (w *writeAPIBlocking) flush(ctx context.Context) error {`
`119`	`119`	`body := strings.Join(w.batch, "\n")`
`120`	`120`	`w.batch = w.batch[:0]`
`121`	`121`	`b := iwrite.NewBatch(body, w.writeOptions.MaxRetryTime())`
`122`		`- return w.service.WriteBatch(ctx, b)`
	`122`	`+ if err:= w.service.WriteBatch(ctx, b); err != nil {`
	`123`	`+ return err`
	`124`	`+ }`
`123`	`125`	`}`
`124`	`126`	`return nil`
`125`	`127`	`}`