Skip to content

Commit e7b305b

Browse files
committed
Fix testing to run on modern systems by using local phantomjs.
Remove phantomjs from package.json. Add testing instruction.
1 parent 64f1c4d commit e7b305b

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

DEVELOP.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ To install dependencies, run
1010

1111
npm install
1212

13+
To install local phantomjs with homebrew on macOS, run
14+
15+
brew install phantomjs
16+
1317
To build dygraphs, run
1418

1519
npm run build

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,9 @@
4848
"jshint": "^2.5.10",
4949
"lcov-parse": "0.0.9",
5050
"mocha": "^2.1.0",
51-
"mocha-phantomjs": "3.5.3",
51+
"mocha-phantomjs": "4.1.0",
5252
"mocha-phantomjs-istanbul": "0.0.2",
5353
"parse-data-uri": "^0.2.0",
54-
"phantomjs": "^1.9.7-8",
5554
"pre-commit": "^1.0.6",
5655
"source-map": "^0.4.2",
5756
"uglify-js": "^2.5.0",

scripts/run-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ trap finish EXIT
2020
sleep 1
2121

2222
# Start the tests
23-
mocha-phantomjs http://localhost:8081/auto_tests/runner.html "$@"
23+
mocha-phantomjs -p $(which phantomjs) http://localhost:8081/auto_tests/runner.html "$@"

0 commit comments

Comments
 (0)