Skip to content

Commit 2d9fdf1

Browse files
committed
refactor(services.py): update function signatures to use the new union type syntax for optional parameters to improve code clarity and maintainability
1 parent 99fd496 commit 2d9fdf1

File tree

1 file changed

+62
-38
lines changed

1 file changed

+62
-38
lines changed

infactory_client/services.py

Lines changed: 62 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ def __init__(self, client):
1919
super().__init__(client)
2020
self.factory = ModelFactory(Project)
2121

22-
def list(self, team_id: str = None, include_deleted: bool = False) -> list[Project]:
22+
def list(
23+
self, team_id: str | None = None, include_deleted: bool = False
24+
) -> list[Project]:
2325
"""
2426
List projects.
2527
@@ -37,7 +39,7 @@ def list(self, team_id: str = None, include_deleted: bool = False) -> list[Proje
3739
response = self._get("v1/projects", params)
3840
return self.factory.create_list(response)
3941

40-
def get(self, project_id: str, team_id: str = None) -> Project:
42+
def get(self, project_id: str, team_id: str | None = None) -> Project:
4143
"""
4244
Get a project by ID.
4345
@@ -55,7 +57,9 @@ def get(self, project_id: str, team_id: str = None) -> Project:
5557
response = self._get(f"v1/projects/{project_id}", params)
5658
return self.factory.create(response)
5759

58-
def create(self, name: str, team_id: str, description: str = None) -> Project:
60+
def create(
61+
self, name: str, team_id: str, description: str | None = None
62+
) -> Project:
5963
"""
6064
Create a new project.
6165
@@ -81,7 +85,7 @@ def create(self, name: str, team_id: str, description: str = None) -> Project:
8185
return project
8286

8387
def update(
84-
self, project_id: str, name: str = None, description: str = None
88+
self, project_id: str, name: str | None = None, description: str | None = None
8589
) -> Project:
8690
"""
8791
Update a project.
@@ -149,7 +153,7 @@ def __init__(self, client):
149153
super().__init__(client)
150154
self.factory = ModelFactory(DataSource)
151155

152-
def list(self, project_id: str = None) -> list[DataSource]:
156+
def list(self, project_id: str | None = None) -> list[DataSource]:
153157
"""
154158
List data sources for a project.
155159
@@ -181,7 +185,11 @@ def get(self, datasource_id: str) -> DataSource:
181185
return self.factory.create(response)
182186

183187
def create(
184-
self, name: str, project_id: str = None, type: str = None, uri: str = None
188+
self,
189+
name: str,
190+
project_id: str | None = None,
191+
type: str | None = None,
192+
uri: str | None = None,
185193
) -> DataSource:
186194
"""
187195
Create a new data source.
@@ -212,7 +220,11 @@ def create(
212220
return self.factory.create(response)
213221

214222
def update(
215-
self, datasource_id: str, name: str = None, type: str = None, uri: str = None
223+
self,
224+
datasource_id: str,
225+
name: str | None = None,
226+
type: str | None = None,
227+
uri: str | None = None,
216228
) -> DataSource:
217229
"""
218230
Update a data source.
@@ -259,9 +271,9 @@ def upload(
259271
self,
260272
datasource_id: str,
261273
file_path: str,
262-
project_id: str = None,
263-
source_url: str = None,
264-
file_type: str = None,
274+
project_id: str | None = None,
275+
source_url: str | None = None,
276+
file_type: str | None = None,
265277
) -> dict:
266278
"""
267279
Upload a file to a data source.
@@ -307,7 +319,7 @@ def __init__(self, client):
307319
super().__init__(client)
308320
self.factory = ModelFactory(DataLine)
309321

310-
def list(self, project_id: str = None) -> list[DataLine]:
322+
def list(self, project_id: str | None = None) -> list[DataLine]:
311323
"""
312324
List data lines for a project.
313325
@@ -341,10 +353,10 @@ def get(self, dataline_id: str) -> DataLine:
341353
def create(
342354
self,
343355
name: str,
344-
project_id: str = None,
345-
dataobject_id: str = None,
346-
schema_code: str = None,
347-
data_model: dict = None,
356+
project_id: str | None = None,
357+
dataobject_id: str | None = None,
358+
schema_code: str | None = None,
359+
data_model: dict | None = None,
348360
) -> DataLine:
349361
"""
350362
Create a new data line.
@@ -378,9 +390,9 @@ def create(
378390
def update(
379391
self,
380392
dataline_id: str,
381-
name: str = None,
382-
dataobject_id: str = None,
383-
data_model: dict = None,
393+
name: str | None = None,
394+
dataobject_id: str | None = None,
395+
data_model: dict | None = None,
384396
) -> DataLine:
385397
"""
386398
Update a data line.
@@ -418,7 +430,9 @@ def update_schema(self, dataline_id: str, schema_code: str) -> DataLine:
418430
Returns:
419431
Updated data line
420432
"""
421-
response = self._patch(f"v1/datalines/{dataline_id}/schema", data=schema_code)
433+
response = self._patch(
434+
f"v1/datalines/{dataline_id}/schema", data={"schema_code": schema_code}
435+
)
422436
return self.factory.create(response)
423437

424438
def delete(self, dataline_id: str, permanent: bool = False) -> DataLine:
@@ -444,7 +458,7 @@ def __init__(self, client):
444458
super().__init__(client)
445459
self.factory = ModelFactory(Team)
446460

447-
def list(self, organization_id: str = None) -> list[Team]:
461+
def list(self, organization_id: str | None = None) -> list[Team]:
448462
"""
449463
List teams.
450464
@@ -478,7 +492,7 @@ def get(self, team_id: str) -> Team:
478492
response = self._get(f"v1/teams/{team_id}")
479493
return self.factory.create(response)
480494

481-
def create(self, name: str, organization_id: str = None) -> Team:
495+
def create(self, name: str, organization_id: str | None = None) -> Team:
482496
"""
483497
Create a new team.
484498
@@ -609,9 +623,9 @@ def get_by_clerk_id(self, clerk_org_id: str) -> Organization:
609623
def create(
610624
self,
611625
name: str,
612-
description: str = None,
613-
platform_id: str = None,
614-
clerk_org_id: str = None,
626+
description: str | None = None,
627+
platform_id: str | None = None,
628+
clerk_org_id: str | None = None,
615629
) -> Organization:
616630
"""
617631
Create a new organization.
@@ -645,7 +659,10 @@ def create(
645659
return org
646660

647661
def update(
648-
self, organization_id: str, name: str = None, description: str = None
662+
self,
663+
organization_id: str,
664+
name: str | None = None,
665+
description: str | None = None,
649666
) -> Organization:
650667
"""
651668
Update an organization.
@@ -711,7 +728,7 @@ def __init__(self, client):
711728
super().__init__(client)
712729
self.factory = ModelFactory(User)
713730

714-
def list(self, organization_id: str = None) -> list[User]:
731+
def list(self, organization_id: str | None = None) -> list[User]:
715732
"""
716733
List users.
717734
@@ -754,9 +771,9 @@ def get_current(self) -> User:
754771
def create(
755772
self,
756773
email: str,
757-
name: str = None,
758-
organization_id: str = None,
759-
role: str = None,
774+
name: str | None = None,
775+
organization_id: str | None = None,
776+
role: str | None = None,
760777
) -> User:
761778
"""
762779
Create a new user.
@@ -785,7 +802,11 @@ def create(
785802
return self.factory.create(response)
786803

787804
def update(
788-
self, user_id: str, email: str = None, name: str = None, role: str = None
805+
self,
806+
user_id: str,
807+
email: str | None = None,
808+
name: str | None = None,
809+
role: str | None = None,
789810
) -> User:
790811
"""
791812
Update a user.
@@ -842,7 +863,10 @@ def move(self, user_id: str, new_organization_id: str) -> User:
842863
return self.factory.create(response)
843864

844865
def get_teams_with_organizations_and_projects(
845-
self, user_id: str = None, clerk_user_id: str = None, email: str = None
866+
self,
867+
user_id: str | None = None,
868+
clerk_user_id: str | None = None,
869+
email: str | None = None,
846870
) -> dict:
847871
"""
848872
Get teams, organizations, and projects for a user.
@@ -881,8 +905,8 @@ def __init__(self, client):
881905

882906
def list(
883907
self,
884-
project_id: str = None,
885-
dataline_id: str = None,
908+
project_id: str | None = None,
909+
dataline_id: str | None = None,
886910
skip: int = 0,
887911
take: int = 100,
888912
include_deleted: bool = False,
@@ -937,7 +961,7 @@ def create(
937961
question: str,
938962
code: str,
939963
dataline_id: str,
940-
project_id: str = None,
964+
project_id: str | None = None,
941965
) -> QueryProgram:
942966
"""
943967
Create a new query program.
@@ -971,9 +995,9 @@ def create(
971995
def update(
972996
self,
973997
queryprogram_id: str,
974-
name: str = None,
975-
question: str = None,
976-
code: str = None,
998+
name: str | None = None,
999+
question: str | None = None,
1000+
code: str | None = None,
9771001
) -> QueryProgram:
9781002
"""
9791003
Update a query program.
@@ -1046,7 +1070,7 @@ def unpublish(self, queryprogram_id: str) -> QueryProgram:
10461070
response = self._patch(f"v1/queryprograms/{queryprogram_id}/unpublish")
10471071
return self.factory.create(response)
10481072

1049-
def evaluate(self, queryprogram_id: str, dataline_id: str = None) -> dict:
1073+
def evaluate(self, queryprogram_id: str, dataline_id: str | None = None) -> dict:
10501074
"""
10511075
Evaluate a query program.
10521076

0 commit comments

Comments
 (0)