Merge pull request #150 from inaka/harenson.149.fix-issues-left-after-pull-146

[Fix #149] Fix dialyzer and code issues left after pull#146

Author: ferigis

README.md

@@ -105,8 +105,7 @@ This would create a comment with the text `Hello` for the issue `username/repo#1
 API Documentation
 =====
 
-There is an automatically generated API documentation page in this project's GitHub page
-[here](http://inaka.github.io/erlang-github/).
+There is an automatically generated API documentation page [here][api_doc].
 
 Example
 =====
@@ -131,3 +130,4 @@ And you can check all of our open-source projects at [inaka.github.io](http://in
 
 [1]: https://developer.github.com/v3/
 [pr_review]: https://developer.github.com/v3/pulls/reviews/
+[api_doc]: https://hexdocs.pm/egithub/

src/egithub_webhook.erl

@@ -36,7 +36,7 @@
 -export_type([req_data/0, message/0, file/0, webhook_target_url/0, review/0]).
 
 -callback handle_pull_request(egithub:credentials(), req_data(), [file()]) ->
-  {ok, [message()]} | {error, term()}.
+  {ok, [message()]} | {ok, review()} | {error, term()}.
 
 -callback handle_error({error, term()}, req_data(), [file()]) ->
     {error, term(),  webhook_target_url()}
@@ -284,8 +284,7 @@ line_comment_exists(Comments, Path, Position, Body) ->
                                 integer(), review() | [message()]) ->
   egithub:result().
 handle_messages_or_review(Cred, Repo, PR, Messages) ->
-  {ok, ReviewStyle} = application:get_env(egithub, review_style, pr_review),
-  case ReviewStyle of
+  case application:get_env(egithub, review_style, pr_review) of
     individual_comments ->
       {ok, LineComments} = egithub:pull_req_comments(Cred, Repo, PR),
       {ok, IssueComments} = egithub:issue_comments(Cred, Repo, PR),