Skip to content

Wildcard matching is too broad when matching linkable existing proxies #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
in03 opened this issue Aug 19, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@in03
Copy link
Owner

in03 commented Aug 19, 2022

Problem

It's cool that these are matching by newest. That's definitely handy. But so far Proxima overwrites originals anyway. Currently this feature exists just to support Resolve's internally generated method which appends digits. In future, we can add support for incrementing files on collision.

Pasted image 20220818122051

Pasted image 20220818122359

What isn't working is the wildcard match. One of the source files is "Cockburn Drone.mov"
Since we're just checking the title starts with "Cockburn Drone" it also matches:

  • "Cockburn Drone - ARC - STBLSD.mov"
  • "Cockburn Drone - End Shots - Stabilised.mov"

If they all exist in the same source folder, they'll be candidates for "Cockburn Drone.mov". This doesn't work in reverse though since "Cockburn Drone" doesn't contain "Cockburn Drone - ARC - STBLSD".

Solution

We could filter linkable matches with regex in user config. Then we could have Resolve's _S000 suffix pattern as a default option as well as maybe - 1 or _1 with varying whitespaces out of the box. Regex would be easiest since it's so flexible and we can make it faster by only running the regex match on initial matches that contain the original filename like we're already doing.

@in03 in03 added the bug Something isn't working label Aug 19, 2022
@in03
Copy link
Owner Author

in03 commented Feb 7, 2023

Fixed by #234

@in03 in03 closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant