Skip to content

Proxies found and linked aren't removed from the queuing list #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
in03 opened this issue Jun 14, 2022 · 1 comment
Closed

Proxies found and linked aren't removed from the queuing list #171

in03 opened this issue Jun 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@in03
Copy link
Owner

in03 commented Jun 14, 2022

Seems like there's just a bit of missing if/else logic, where the reduced list is only returned after handling a link-fail prompt.

Lines 266-296:

if link_success:
        print(f"[green]Succeeded linking: [/]{len(link_success)}")

    if link_fail:
        print(f"[red]Failed linking: [/]{len(link_fail)}")

    print()

    print(f"[green]{len(link_success)} proxy(s) successfully linked.")

    if link_fail:

        if Confirm.ask(
            f"[yellow]{len(link_fail)} proxies failed to link. Would you like to re-render them?"
        ):
            # Remove offline status, redefine media list
            for x in media_list:
                if x in link_fail:
                    x["proxy_status"] = "None"

            media_list = [x for x in media_list if x not in link_success]

    else:

        # Queue only those that remain
        media_list = [
            x for x in media_list if x not in link_success or x not in link_fail
        ]

    logger.debug(f"[magenta]Remaining unlinked media: {media_list}")
    return media_list
    ```

    Just remove the `else` block and add another return after redefining the media_list in that `if link_fail` block.

<!-- Edit the body of your new issue then click the ✓ "Create Issue" button in the top right of the editor. The first line will be the issue title. Assignees and Labels follow after a blank line. Leave an empty line before beginning the body of the issue. -->
@in03 in03 added the bug Something isn't working label Jun 14, 2022
@in03 in03 self-assigned this Jun 14, 2022
@in03
Copy link
Owner Author

in03 commented Jun 14, 2022

Fixed in #172

@in03 in03 closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant