Skip to content

Commit 71ad145

Browse files
committed
[actions] split out tests into new vs old eslint
We started exceeding the 256 job per workflow limit
1 parent 9b096c4 commit 71ad145

File tree

2 files changed

+72
-51
lines changed

2 files changed

+72
-51
lines changed

.github/workflows/eslint-8+.yml

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
name: 'Tests: eslint 8+'
2+
3+
on: [pull_request, push]
4+
5+
concurrency:
6+
group: ${{ github.workflow }}-${{ github.ref }}
7+
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
8+
9+
permissions:
10+
contents: read
11+
12+
jobs:
13+
matrix:
14+
runs-on: ubuntu-latest
15+
outputs:
16+
latest: ${{ steps.set-matrix.outputs.requireds }}
17+
minors: ${{ steps.set-matrix.outputs.optionals }}
18+
steps:
19+
- uses: ljharb/actions/node/matrix@main
20+
id: set-matrix
21+
with:
22+
versionsAsRoot: true
23+
type: majors
24+
preset: '^12.22.0 || ^14.17.0 || >=16.0.0' # eslint 8 engines.node
25+
26+
latest:
27+
needs: [matrix]
28+
name: majors
29+
runs-on: ${{ matrix.os }}
30+
31+
strategy:
32+
fail-fast: false
33+
matrix:
34+
os:
35+
- ubuntu-latest
36+
- macos-latest
37+
node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
38+
eslint:
39+
- 9
40+
- 8
41+
exclude:
42+
- node-version: 16
43+
eslint: 9
44+
- node-version: 14
45+
eslint: 9
46+
- node-version: 12
47+
eslint: 9
48+
49+
steps:
50+
- uses: actions/checkout@v4
51+
- uses: ljharb/actions/node/install@main
52+
name: 'nvm install ${{ matrix.node-version }} && npm install, with eslint ${{ matrix.eslint }}'
53+
env:
54+
ESLINT_VERSION: ${{ matrix.eslint }}
55+
TRAVIS_NODE_VERSION: ${{ matrix.node-version }}
56+
with:
57+
node-version: ${{ matrix.node-version }}
58+
after_install: npm run copy-metafiles && ./tests/dep-time-travel.sh
59+
skip-ls-check: true
60+
- run: npm run pretest
61+
- run: npm run tests-only
62+
- uses: codecov/[email protected]
63+
64+
node:
65+
name: 'eslint 8+'
66+
needs: [latest]
67+
runs-on: ubuntu-latest
68+
steps:
69+
- run: true

.github/workflows/node-4+.yml renamed to .github/workflows/eslint-old.yml

Lines changed: 3 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Tests: node.js'
1+
name: 'Tests: eslint (old versions)'
22

33
on: [pull_request, push]
44

@@ -36,8 +36,6 @@ jobs:
3636
- macos-latest
3737
node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
3838
eslint:
39-
- 9
40-
- 8
4139
- 7
4240
- 6
4341
- 5
@@ -64,70 +62,24 @@ jobs:
6462
env:
6563
TS_PARSER: 2
6664
exclude:
67-
- node-version: 16
68-
eslint: 9
69-
- node-version: 15
70-
eslint: 9
71-
- node-version: 15
72-
eslint: 8
73-
- node-version: 14
74-
eslint: 9
75-
- node-version: 13
76-
eslint: 9
77-
- node-version: 13
78-
eslint: 8
79-
- node-version: 12
80-
eslint: 9
81-
- node-version: 11
82-
eslint: 9
83-
- node-version: 11
84-
eslint: 8
85-
- node-version: 10
86-
eslint: 9
87-
- node-version: 10
88-
eslint: 8
89-
- node-version: 9
90-
eslint: 9
91-
- node-version: 9
92-
eslint: 8
9365
- node-version: 9
9466
eslint: 7
95-
- node-version: 8
96-
eslint: 9
97-
- node-version: 8
98-
eslint: 8
9967
- node-version: 8
10068
eslint: 7
101-
- node-version: 7
102-
eslint: 9
103-
- node-version: 7
104-
eslint: 8
10569
- node-version: 7
10670
eslint: 7
10771
- node-version: 7
10872
eslint: 6
109-
- node-version: 6
110-
eslint: 9
111-
- node-version: 6
112-
eslint: 8
11373
- node-version: 6
11474
eslint: 7
11575
- node-version: 6
11676
eslint: 6
117-
- node-version: 5
118-
eslint: 9
119-
- node-version: 5
120-
eslint: 8
12177
- node-version: 5
12278
eslint: 7
12379
- node-version: 5
12480
eslint: 6
12581
- node-version: 5
12682
eslint: 5
127-
- node-version: 4
128-
eslint: 9
129-
- node-version: 4
130-
eslint: 8
13183
- node-version: 4
13284
eslint: 7
13385
- node-version: 4
@@ -153,8 +105,8 @@ jobs:
153105
- uses: codecov/[email protected]
154106

155107
node:
156-
name: 'node 4+'
108+
name: 'eslint 2 - 7'
157109
needs: [latest]
158110
runs-on: ubuntu-latest
159111
steps:
160-
- run: 'echo tests completed'
112+
- run: true

0 commit comments

Comments
 (0)