Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add postcss dependency to fix build error #606

Merged
merged 3 commits into from
Feb 24, 2021
Merged

fix: add postcss dependency to fix build error #606

merged 3 commits into from
Feb 24, 2021

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Feb 24, 2021

Description

  • This PR adds postcss library as a dependency, since it was missing and causing errors
  • It also updated the contributing docs to reflect the need for Java to run build scripts.

@luqven luqven added the dependencies Pull requests that update a dependency file label Feb 24, 2021
@luqven luqven requested a review from a team February 24, 2021 15:04
@luqven luqven self-assigned this Feb 24, 2021
@commit-lint
Copy link

commit-lint bot commented Feb 24, 2021 •
edited
Loading

Bug Fixes

  • add postcss dependency to fix build error (dacccb1)

Chore

  • contrib: add node about java dep for builds (a9836f7)
  • Update CONTRIBUTING.md to bold not quote (e85994b)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

sherwinski
sherwinski approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luqven luqven merged commit a48f0ac into main Feb 24, 2021
@luqven luqven deleted the luis/postcssFix branch February 24, 2021 20:29
@luqven luqven mentioned this pull request Feb 26, 2021
Merged
frederickfogerty
frederickfogerty reviewed Mar 1, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅✅

@frederickfogerty
Copy link
Contributor

FYI if anyone comes here in the future. We installed the version 8.1.0 of postcss since later versions broke the build. This might not be the case in the future but if there are build issues with postcss, try downgrading to this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederickfogerty frederickfogerty frederickfogerty left review comments

@sherwinski sherwinski sherwinski approved these changes

Assignees

@luqven luqven

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luqven @frederickfogerty @sherwinski