Skip to content

Enhance Comet Startup by Monitoring Heroic and Game Launches #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RubenKelevra opened this issue Aug 1, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@RubenKelevra
Copy link

RubenKelevra commented Aug 1, 2024

Is your feature request related to a problem? Please describe.
I followed the installation instructions and was curious: why do we need to add a script to Heroic to detect when a game starts?

Describe the solution you'd like
How about running a small service that first checks for Heroic's startup and then monitors game startups via the fanotify API on the Linux Kernel? This service could subscribe to execution events, so when Heroic and subsequently a game launches, the FAN_OPEN_EXEC event triggers, allowing Comet to automatically start for the game.

@RubenKelevra RubenKelevra added the enhancement New feature or request label Aug 1, 2024
@imLinguin
Copy link
Owner

Comet is designed to be managed by each game client. Although your suggestions is valid.
There is a pull request in Heroic integrating comet for all GOG games Heroic-Games-Launcher/HeroicGamesLauncher#3727
with that no manual steps will be necessary

@imLinguin
Copy link
Owner

Now that Heroic 2.15.0 released I think there is no longer any need for this

@RubenKelevra
Copy link
Author

Yeah read that, that's so great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants