Restore VSCode settings in uninstall hook

Author: illixion

changelog.md

@@ -1,3 +1,7 @@
+# 1.1.52
+
+* Updated uninstall hook to also attempt to restore VSCode config settings
+
 # 1.1.51
 
 * Reduced package size to ~1 MB by not bundling dev dependencies

extension/index.js

@@ -531,7 +531,7 @@ function activate(context) {
 
       // Update settings if necessary
       let newColorCustomization = {};
-      if (currentBackground !== "#00000000" || currentGpuAcceleration !== "off") {
+      if (currentBackground !== "#00000000") {
         newColorCustomization = {
           ...currentColorCustomizations,
           "terminal.background": "#00000000"
@@ -571,6 +571,8 @@ function activate(context) {
 
     // Save user customizations
     await context.globalState.update('customizations', previousCustomizations);
+
+    return previousCustomizations;
   }
 
   // Function to restore previous settings on uninstall
@@ -635,22 +637,30 @@ function activate(context) {
     );
 
     return configFilePath;
-}
+  }
 
-async function setLocalConfig(state, paths) {
+  async function setLocalConfig(state, paths, previousCustomizations) {
     const configFilePath = await getLocalConfigPath();
 
+    // Convert undefined values in previousCustomizations to null
+    if (previousCustomizations && typeof previousCustomizations === 'object') {
+      previousCustomizations = Object.fromEntries(
+          Object.entries(previousCustomizations).map(([key, value]) => [key, value === undefined ? null : value])
+      );
+    }
+
     if (state) {
-        const configData = {
-            workbenchHtmlPath: paths.workbenchHtmlPath,
-            jsPath: paths.jsPath,
-            electronJsPath: paths.electronJsPath
-        };
-        await fs.writeFile(configFilePath, JSON.stringify(configData, null, 2), 'utf-8');
+      const configData = {
+        workbenchHtmlPath: paths.workbenchHtmlPath,
+        jsPath: paths.jsPath,
+        electronJsPath: paths.electronJsPath,
+        previousCustomizations,
+      };
+      await fs.writeFile(configFilePath, JSON.stringify(configData, null, 2), 'utf-8');
     } else {
         await fs.unlink(configFilePath).catch(() => { });
     }
-}
+  }
 
 
   // ####  main commands ######################################################
@@ -679,14 +689,13 @@ async function setLocalConfig(state, paths) {
       }
       await installJS();
       await installHTML();
-      await changeVSCodeSettings();
       await checkColorTheme();
       await checkElectronDeprecatedType();
       await setLocalConfig(true, {
         workbenchHtmlPath: HTMLFile,
         jsPath: JSFile,
-        electronJsPath: ElectronJSFile
-      });
+        electronJsPath: ElectronJSFile,
+      }, await changeVSCodeSettings());
     } catch (error) {
       if (error && (error.code === 'EPERM' || error.code === 'EACCES')) {
         vscode.window.showInformationMessage(localize('messages.admin') + error);

extension/uninstallHook.js

@@ -2,6 +2,116 @@ const { spawn, exec } = require('child_process');
 const fs = require('fs').promises; // Use fs.promises for Promise-based APIs
 const fsSync = require('fs'); // Import standard fs for synchronous methods
 const path = require('path');
+const os = require('os');
+
+function getVSCodeSettingsPath() {
+    const platform = os.platform();
+    const home = os.homedir();
+
+    if (platform === 'win32') {
+        return path.join(process.env.APPDATA, 'Code', 'User', 'settings.json');
+    } else if (platform === 'darwin') {
+        return path.join(home, 'Library', 'Application Support', 'Code', 'User', 'settings.json');
+    } else {
+        // Assume Linux
+        return path.join(home, '.config', 'Code', 'User', 'settings.json');
+    }
+}
+
+// Function to restore previous settings
+// Because VSCode uses JSONC, we need to be careful with comments
+// and formatting. We will use regex to find and replace the specific settings.
+function restorePreviousSettings(previousCustomizations) {
+    const settingsPath = getVSCodeSettingsPath();
+
+    if (!fsSync.existsSync(settingsPath)) {
+        console.error('VSCode settings.json not found!');
+        return;
+    }
+
+    let settingsContent = '';
+    try {
+        settingsContent = fsSync.readFileSync(settingsPath, 'utf-8');
+    } catch (err) {
+        console.error('Failed to read settings.json:', err);
+        return;
+    }
+
+    // Remove transparent terminal background
+    settingsContent = settingsContent.replace(
+        /"terminal\.background"\s*:\s*"#00000000",?\s*/g,
+        ''
+    );
+
+    // Restore saved customizations
+    if (previousCustomizations?.saved) {
+        if (previousCustomizations.terminalBackground !== null) {
+            if (
+                previousCustomizations.terminalBackground === '#00000000'
+            ) {
+                settingsContent = settingsContent.replace(
+                    /"terminal\.background"\s*:\s*".*?",?\s*/g,
+                    ''
+                );
+            } else {
+                settingsContent = settingsContent.replace(
+                    /"terminal\.background"\s*:\s*".*?",?\s*/g,
+                    `"terminal.background": "${previousCustomizations.terminalBackground}",`
+                );
+            }
+        }
+
+        if (previousCustomizations.systemColorTheme !== null) {
+            settingsContent = settingsContent.replace(
+                /"window\.systemColorTheme"\s*:\s*".*?",?\s*/g,
+                previousCustomizations.systemColorTheme === null
+                    ? ''
+                    : `"window.systemColorTheme": "${previousCustomizations.systemColorTheme}",`
+            );
+        } else {
+            settingsContent = settingsContent.replace(
+                /"window\.systemColorTheme"\s*:\s*".*?",?\s*/g,
+                ''
+            );
+        }
+
+        if (previousCustomizations.autoDetectColorScheme !== null) {
+            settingsContent = settingsContent.replace(
+                /"window\.autoDetectColorScheme"\s*:\s*(true|false),?\s*/g,
+                previousCustomizations.autoDetectColorScheme === null
+                    ? ''
+                    : `"window.autoDetectColorScheme": ${previousCustomizations.autoDetectColorScheme},`
+            );
+        } else {
+            settingsContent = settingsContent.replace(
+                /"window\.autoDetectColorScheme"\s*:\s*(true|false),?\s*/g,
+                ''
+            );
+        }
+
+        if (previousCustomizations.gpuAcceleration !== null) {
+            settingsContent = settingsContent.replace(
+                /"terminal\.integrated\.gpuAcceleration"\s*:\s*".*?",?\s*/g,
+                previousCustomizations.gpuAcceleration === null
+                    ? ''
+                    : `"terminal.integrated.gpuAcceleration": "${previousCustomizations.gpuAcceleration}",`
+            );
+        } else {
+            settingsContent = settingsContent.replace(
+                /"terminal\.integrated\.gpuAcceleration"\s*:\s*".*?",?\s*/g,
+                ''
+            );
+        }
+    }
+
+    // Write updated settings back to disk
+    try {
+        fsSync.writeFileSync(settingsPath, settingsContent.trim() + '\n', 'utf-8');
+        console.log('VSCode settings.json successfully reverted.');
+    } catch (err) {
+        console.error('Failed to write settings.json:', err);
+    }
+}
 
 (async () => {
     const envPaths = (await import('env-paths')).default;
@@ -58,10 +168,11 @@ const path = require('path');
 
     const config = loadConfig();
     if (config) {
-        const { workbenchHtmlPath, jsPath, electronJsPath } = config;
+        const { workbenchHtmlPath, jsPath, electronJsPath, previousCustomizations } = config;
 
         await uninstallJS(jsPath, electronJsPath);
         await uninstallHTML(workbenchHtmlPath);
+        restorePreviousSettings(previousCustomizations);
 
         showNotification("Vibrancy Continued has been removed. Please restart VSCode to apply changes.");
     }