Merge pull request #382 from igorkasyanchuk/364-active_storage_validations-200-causing-stack-level-too-deep

364 active storage validations 200 causing stack level too deep

Author: Mth0158

CHANGES.md

@@ -1,5 +1,6 @@
 - 2.0.4
   - Fix issue when updating a child record through a parent (like: parent_model.update(child_attributes: { image: file })) for Rails >= 8.0.2 (https://github.com/igorkasyanchuk/active_storage_validations/pull/378)
+  - Fix issue causing a stack error too deep edge case (not reproductible) because of the `after: :load_config_initializers` option (https://github.com/igorkasyanchuk/active_storage_validations/pull/382)
 
 - 2.0.3
   - Allow to pass an Array, a splatted Array, or a single string for allowing / rejecting content_type matcher methods (https://github.com/igorkasyanchuk/active_storage_validations/pull/372)

Gemfile

@@ -23,6 +23,9 @@ group :development, :test do
   # To use debugger:
   # gem "debug", "~> 1.10", ">= 1.10.0"
 
+  # To test S3 services
+  # gem "aws-sdk-s3", require: false
+
   # Linters
   gem "rubocop", "~> 1.71", ">= 1.71.1", require: false
   gem "rubocop-performance", "~> 1.23", ">= 1.23.1", require: false

lib/active_storage_validations/railtie.rb

@@ -2,15 +2,18 @@
 
 module ActiveStorageValidations
   class Railtie < ::Rails::Railtie
-    initializer "active_storage_validations.configure", after: :load_config_initializers do
+    # Using after: :load_config_initializers would cause a stack level too deep error
+    # See: https://github.com/igorkasyanchuk/active_storage_validations/issues/364
+
+    initializer "active_storage_validations.configure" do
       ActiveSupport.on_load(:active_record) do
-        send :include, ActiveStorageValidations
+        include ActiveStorageValidations
       end
     end
 
     initializer "active_storage_validations.extend_active_storage_blob" do
       ActiveSupport.on_load(:active_storage_blob) do
-        include(ActiveStorageValidations::ASVBlobMetadatable)
+        include ActiveStorageValidations::ASVBlobMetadatable
       end
     end
   end

test/dummy/app/models/active_storage_validations/check.rb

@@ -20,4 +20,9 @@ class ActiveStorageValidations::Check < ApplicationRecord
   # its own custom mime types
   has_one_attached :asv_test
   validates :asv_test, content_type: "application/asv_test"
+
+  # This validator is related to a test that we can download files from a
+  # service
+  has_one_attached :digitalocean
+  validates :digitalocean, content_type: "image/png"
 end

test/dummy/config/storage.yml

@@ -1,3 +1,11 @@
 test:
   service: Disk
   root: <%= Rails.root.join('tmp/storage') %>
+
+digitalocean:
+  service: S3
+  endpoint: https://nyc3.digitaloceanspaces.com
+  access_key_id: xxxx
+  secret_access_key: xxx
+  bucket: active_storage_validations_test
+  region: eu-west-1

test/global/active_storage_validations_test.rb

@@ -30,4 +30,16 @@
       assert_equal(Marcel::MimeType.for(declared_type: "application/asv_test"), "application/asv_test")
     end
   end
+
+  describe "services" do
+    # Uncomment this after having uncommented the S3 service in test_helper.rb
+    #
+    # describe "digitalocean" do
+    #   subject { instance }
+
+    #   it "works fine with the digitalocean service" do
+    #     subject.digitalocean.attach(png_file)
+    #   end
+    # end
+  end
 end

test/test_helper.rb

@@ -13,6 +13,11 @@
 Combustion.path = "test/dummy"
 Combustion.initialize! :active_record, :active_storage, :active_job do
   config.active_storage.variant_processor = ENV["IMAGE_PROCESSOR"]&.to_sym
+
+  # Uncomment this to test S3 services
+  # require "aws-sdk-s3"
+  # config.active_storage.service = :digitalocean
+
   config.active_job.queue_adapter = :inline
 end