Skip to content

Hide 'stanza reconstruction' behind configuration #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guusdk opened this issue Sep 8, 2020 · 1 comment
Open

Hide 'stanza reconstruction' behind configuration #117

guusdk opened this issue Sep 8, 2020 · 1 comment

Comments

@guusdk
Copy link
Member

guusdk commented Sep 8, 2020

When only a message body, and not the original stanza, is persisted, the plugin attempts to reconstruct a stanza. This is a suboptimal solution, as data will have been lost. MAM results based on this reconstruction will be imprecise, which can lead to bugs.

This feature should be made configurable, and turned off by default.

Note that for personal archives, stanzas are now always persisted if message archiving is enabled (this might not have been the case in the past - old databases might have null values in the stanza column). For MUC archives, stanza persistence is controlled by an additional flag. (This inconsistency should be removed. See #116 )

@guusdk guusdk changed the title Hide 'stanza reconsturction' behind configuration Hide 'stanza reconstruction' behind configuration Sep 8, 2020
@Fishbowler
Copy link
Member

Perhaps less suboptimal following changes made in #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants