fix(oracle): return a sqlglot.DataType, not str, when compiling string dtype
#11124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCrews
added
datatypes
cpcloud
changed the title
sqlglot.DataType, not str, when compiling string dtype
cpcloud
approved these changes
Apr 15, 2025
cpcloud
force-pushed
the
oracle-string-dtype-compile
branch
from
18d1cdb to
5c1e6fa
Compare
github-actions
bot
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out this fix for Oracle from #11100
I wasn't sure how to test this. If you have an idea, let me know, otherwise I think I'm fine getting this in with no test. It is about to be tested once #11100 lands.