feat(flink): support StringSplit
#11049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
cpcloud
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
I've simplified the implementation a bit.
We can rely solely on the test in test_string.py for now, and since StringSplit is already mapped to "split" in the base compiler class we don't can simply remove ops.StringSplit from the UNSUPPORTED_OPS list in the Flink compiler.
I also removed the same (redundant) mapping from the Databricks compiler.
cpcloud
changed the title
StringSplit
ted0928
added a commit
to ted0928/ibis
that referenced
this pull request
Apr 10, 2025
* origin/main: chore: make gdal buildable on macos arm64 chore(deps): bump and relock chore(deps): update astral-sh/setup-uv action to v5.4.1 chore(deps): update ghcr.io/astral-sh/uv docker tag to v0.6.11 test(datafusion): enable various xpassing tests chore(deps): bump and relock chore(deps): update `flake.lock` chore(deps): bump and relock fix(postgres): clean up possible transaction hangs chore(deps): update actions/create-github-app-token action to v1.12.0 chore(deps): update clickhouse/clickhouse-server docker tag to v25.3.2.39 chore(release): 10.4.0 chore(deps): bump and relock (ibis-project#11050) feat(datatypes): add string length (ibis-project#11045) feat(flink): support `StringSplit` (ibis-project#11049) chore(deps): update ghcr.io/astral-sh/uv docker tag to v0.6.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issues closed