Skip to content

feat(postgres): implement support for asof_join API via a lateral join #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

zblz
Copy link
Contributor

@zblz zblz commented Mar 20, 2025

Description of changes

Implement support for asof_join API in postgres compiler. The implementations works around the lack of ASOF key in Postgres by implementing it as a lateral subquery join. This implementation is inspired by some posts on this thread of the pg-hackers mailing list.

Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

See https://github.com/ibis-project/ibis/blob/main/.releaserc.js
for the list of acceptable prefixes, eg "feat:", "fix:", "chore:", etc.

The commitlint output is:

npm warn exec The following package was not found and will be installed: [email protected]
⧗   input: feat(postgres): Implement support for `asof_join` API via a lateral join

## Description of changes

Implement support for `asof_join` API in postgres compiler. The implementations works around the lack of ASOF key in Postgres by implementing it as a lateral subquery join. This implementation is inspired by some posts on [this thread](https://www.postgresql.org/message-id/flat/bc494762-26bd-b100-e1f9-a97901ddad57%40postgrespro.ru) of the `pg-hackers` mailing list.
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@github-actions github-actions bot added tests Issues or PRs related to tests sql Backends that generate SQL labels Mar 20, 2025
@zblz zblz changed the title feat(postgres): Implement support for asof_join API via a lateral join feat(postgres): implement support for asof_join API via a lateral join Mar 20, 2025
@zblz zblz force-pushed the postgresql-asof-join branch 2 times, most recently from 42099b6 to 05e11cc Compare March 20, 2025 23:39
@cpcloud cpcloud force-pushed the postgresql-asof-join branch from 05e11cc to 7607886 Compare March 23, 2025 12:57
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great work, thank you!

@cpcloud cpcloud merged commit 8eb9d33 into ibis-project:main Mar 23, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants