Skip to content

feat(python): support python 3.9 again #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 6, 2025

Description of changes

This PR brings back support for Python 3.9, which I know is maybe a bit controversial.

In retrospect, I'm not sure that Ibis should necessarily follow NEP 29 given that it's not particularly
sensitive to things that NumPy and SciPy are, like ABI changes across Python versions.

Of course, given what this PR does, the previous statement may seem a bit self-serving, but I do think that it will be less effort to support the official Python lifecycle than it is for NumPy.

I know there's also an ask for this in #10064, which hopefully this PR will resolve. Ibis has an external customer that is also requesting support for Ibis 3.9 to deploy it across an organization.

Issues closed

Resolves #10064.

@cpcloud cpcloud changed the title chore: support python 3.9 chore: support python 3.9 again Mar 6, 2025
@github-actions github-actions bot added tests Issues or PRs related to tests postgres The PostgreSQL backend sqlite The SQLite backend ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies bigquery The BigQuery backend datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) sql Backends that generate SQL nix Issues or PRs related to nix labels Mar 6, 2025
@gforsyth
Copy link
Member

gforsyth commented Mar 6, 2025

Eh, I'm not going to block. I don't really understand an org-wide deployment on a version of Python with <7 months left before EOL, but hey, different strokes.

@ianmcook
Copy link
Contributor

ianmcook commented Mar 7, 2025

Thanks @cpcloud. For transparency: Extended Python 3.9 support is critically important to enable one of Voltron Data's customers to use Ibis during the next several months while they work to complete a difficult company-wide upgrade to a newer version of Python. Voltron Data is sponsoring this work. I appreciate the understanding of these kinds of realities that emerge as Ibis moves into mainstream use within large organizations with huge Python codebases.

@cpcloud cpcloud force-pushed the python39 branch 2 times, most recently from a77b7f1 to d255519 Compare March 7, 2025 13:06
@cpcloud cpcloud marked this pull request as ready for review March 7, 2025 13:09
@cpcloud cpcloud force-pushed the python39 branch 4 times, most recently from 23950aa to 97d913e Compare March 7, 2025 16:59
@cpcloud cpcloud changed the title chore: support python 3.9 again feat(python): support python 3.9 again Mar 7, 2025
@cpcloud cpcloud merged commit 786d8f0 into ibis-project:main Mar 7, 2025
110 checks passed
@cpcloud cpcloud deleted the python39 branch March 7, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend ci Continuous Integration issues or PRs datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix postgres The PostgreSQL backend sql Backends that generate SQL sqlite The SQLite backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop NEP 29 in favor of official python version support
3 participants