Skip to content

chore(dev-deps): move to uv for development #10424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 3, 2024

Description of changes

This PR moves our dependency management over to uv.

Wanted to get a head start on CI and see what shakes out.

TODOs:

  • uv2nix issue that needs to be fixed. This is fixed
  • preserve existing dev versioning scheme (right now it's major.post$N.dev0).
  • nix package builds (that's what runs tests in the nix.yml GHA workflows) aren't working at all right now not working the way I'd like, but tests are being run similarly to how they were under poetry2nix.
  • release scripts need to be ported, but I think I can mostly keep them the same

@cpcloud cpcloud marked this pull request as draft November 3, 2024 14:22
@github-actions github-actions bot added docs Documentation related issues or PRs ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix labels Nov 3, 2024
@cpcloud cpcloud force-pushed the move-to-uv branch 4 times, most recently from 0347f92 to edfa514 Compare November 4, 2024 12:02
@cpcloud cpcloud added this to the 10.0 milestone Nov 4, 2024
@cpcloud cpcloud force-pushed the move-to-uv branch 8 times, most recently from 4d05fdb to 42dc85d Compare November 4, 2024 17:26
@github-actions github-actions bot added the tests Issues or PRs related to tests label Nov 4, 2024
@cpcloud cpcloud force-pushed the move-to-uv branch 5 times, most recently from bfab12d to 36ae765 Compare November 4, 2024 19:57
@cpcloud cpcloud marked this pull request as ready for review November 4, 2024 19:58
@cpcloud cpcloud force-pushed the move-to-uv branch 5 times, most recently from 5dfb9bf to 7da5a1b Compare November 5, 2024 11:27
@cpcloud
Copy link
Member Author

cpcloud commented Nov 6, 2024

I've opened pyproject-nix/pyproject.nix#173 for the pyproject.nix work, but that isn't necessary to merge this PR, we're still running tests in per-python-version isolated nix environments, we're just not doing it through the usual test-during-package-builds mechanism.

@cpcloud
Copy link
Member Author

cpcloud commented Nov 6, 2024

Ok, I've somewhat improved the nix builds. I'm still not sure if the way I did it is 100% kosher, but now the nix builds have the same behavior as before: they're testing ibis as part of a package build.

@cpcloud cpcloud force-pushed the move-to-uv branch 5 times, most recently from 723b1f1 to d91eed2 Compare November 6, 2024 13:51
@adisbladis
Copy link
Contributor

Ok, I've somewhat improved the nix builds. I'm still not sure if the way I did it is 100% kosher, but now the nix builds have the same behavior as before: they're testing ibis as part of a package build.

I've made of the uv2nix usage more idiomatic & tidied up the confusion re buildPythonPackage in cpcloud#27

@cpcloud cpcloud force-pushed the move-to-uv branch 3 times, most recently from 15a8e99 to c5071a3 Compare November 10, 2024 11:05
@cpcloud cpcloud force-pushed the move-to-uv branch 9 times, most recently from 25453a4 to cad3008 Compare November 10, 2024 12:12
@cpcloud
Copy link
Member Author

cpcloud commented Nov 10, 2024

Merging, so that I can work out any kinks in the cloud CI.

@cpcloud cpcloud merged commit dad2acc into ibis-project:main Nov 10, 2024
90 checks passed
@cpcloud cpcloud deleted the move-to-uv branch November 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development docs Documentation related issues or PRs nix Issues or PRs related to nix tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants