fix(mssql): fix strip, lstrip, rstrip

Author: gforsyth

ibis/backends/sql/dialects.py

@@ -330,7 +330,6 @@ class Generator(TSQL.Generator):
             sge.Variance: rename_func("var"),
             sge.VariancePop: rename_func("varp"),
             sge.Ceil: rename_func("ceiling"),
-            sge.Trim: lambda self, e: f"TRIM({e.this.sql(self.dialect)})",
             sge.DateFromParts: rename_func("datefromparts"),
         }
 

ibis/backends/tests/test_string.py

@@ -1265,7 +1265,7 @@ def string_temp_table(backend, con):
             id="lstrip",
             marks=[
                 pytest.mark.notimpl(
-                    ["clickhouse", "impala", "pyspark", "mssql"],
+                    ["clickhouse", "impala", "pyspark"],
                     raises=AssertionError,
                     reason="doesn't strip newline or tabs",
                 ),
@@ -1282,7 +1282,7 @@ def string_temp_table(backend, con):
             id="rstrip",
             marks=[
                 pytest.mark.notimpl(
-                    ["clickhouse", "impala", "pyspark", "mssql"],
+                    ["clickhouse", "impala", "pyspark"],
                     raises=AssertionError,
                     reason="doesn't strip newline or tabs",
                 ),
@@ -1299,7 +1299,7 @@ def string_temp_table(backend, con):
             id="strip",
             marks=[
                 pytest.mark.notimpl(
-                    ["impala", "mssql"],
+                    ["impala"],
                     raises=AssertionError,
                     reason="""
                     not stripping anything but space