depr(api): deprecate get_column/s in favor of __getitem__/__getattr__ syntax

Author: cpcloud

ibis/expr/sql.py

@@ -233,7 +233,7 @@ def convert_binary(binary, catalog):
         # expr is a table expression
         assert len(expr.columns) == 1
         name = expr.columns[0]
-        expr = expr.get_column(name)
+        expr = expr[name]
 
     return op(this, expr)
 

ibis/expr/types/relations.py

@@ -115,7 +115,7 @@ def __getitem__(self, what):
         from ibis.expr.types.logical import BooleanValue
 
         if isinstance(what, (str, int)):
-            return self.get_column(what)
+            return ops.TableColumn(self, what).to_expr()
 
         if isinstance(what, slice):
             step = what.step
@@ -154,7 +154,7 @@ def __len__(self):
 
     def __getattr__(self, key):
         with contextlib.suppress(com.IbisTypeError):
-            return self.get_column(key)
+            return ops.TableColumn(self, key).to_expr()
 
         # Handle deprecated `groupby` and `sort_by` methods
         if key == "groupby":
@@ -210,33 +210,39 @@ def _ensure_expr(self, expr):
         else:
             return expr
 
+    @util.deprecated(
+        version="5.0", instead="use a list comprehension and attribute/getitem syntax"
+    )
     def get_columns(self, iterable: Iterable[str]) -> list[Column]:
         """Get multiple columns from the table.
 
+        Parameters
+        ----------
+        iterable
+            An iterable of column names
+
         Examples
         --------
         >>> import ibis
-        >>> table = ibis.table(
-        ...    [
-        ...        ('a', 'int64'),
-        ...        ('b', 'string'),
-        ...        ('c', 'timestamp'),
-        ...        ('d', 'float'),
-        ...    ],
-        ...    name='t'
-        ... )
+        >>> table = ibis.table(dict(a='int64', b='string', c='timestamp', d='float'))
         >>> a, b, c = table.get_columns(['a', 'b', 'c'])
 
         Returns
         -------
         list[ir.Column]
             List of column expressions
         """
-        return [self.get_column(x) for x in iterable]
+        return list(map(self.get_column, iterable))
 
+    @util.deprecated(version="5.0", instead="use t.<name> or t[name]")
     def get_column(self, name: str) -> Column:
         """Get a reference to a single column from the table.
 
+        Parameters
+        ----------
+        name
+            A column name
+
         Returns
         -------
         Column