Skip to content

Commit e4bae26

Browse files
kszucscpcloud
authored andcommitted
depr(ir): schedule DatabaseTable.change_name for removal
1 parent db24173 commit e4bae26

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

ibis/backends/impala/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ def rename(self, new_name, database=None):
382382
statement = RenameTable(self._qualified_name, new_name, new_database=database)
383383
self._client.raw_sql(statement)
384384

385-
op = self.op().change_name(statement.new_qualified_name)
385+
op = self.op().copy(name=statement.new_qualified_name)
386386
return type(self)(op)
387387

388388
@property

ibis/backends/pyspark/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def rename(self, new_name: str) -> PySparkTable:
160160
statement = ddl.RenameTable(self._qualified_name, new_name)
161161
self._client.raw_sql(statement.compile())
162162

163-
op = self.op().change_name(new_qualified_name)
163+
op = self.op().copy(name=new_qualified_name)
164164
return type(self)(op)
165165

166166
def alter(self, tbl_properties: Mapping[str, str] | None = None) -> Any:

ibis/expr/operations/relations.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ class DatabaseTable(PhysicalTable):
5959
schema = rlz.instance_of(sch.Schema)
6060
source = rlz.client
6161

62+
@util.deprecated(instead=".copy(name=new_name)", version="4.1")
6263
def change_name(self, new_name):
63-
return type(self)(new_name, self.args[1], self.source)
64+
return self.copy(name=new_name)
6465

6566

6667
@public

0 commit comments

Comments
 (0)