refactor(ir): remove UnnamedMarker

Author: kszucs

ibis/backends/base/sql/alchemy/registry.py

@@ -138,7 +138,7 @@ def _exists_subquery(t, op):
     filtered = (
         op.foreign_table.to_expr()
         .filter([pred.to_expr() for pred in op.predicates])
-        .projection([ir.literal(1).name(ir.core.unnamed)])
+        .projection([ir.literal(1).name("")])
     )
 
     sub_ctx = ctx.subcontext()

ibis/backends/base/sql/compiler/translator.py

@@ -8,7 +8,6 @@
 import ibis.common.exceptions as com
 import ibis.expr.operations as ops
 from ibis.backends.base.sql.registry import operation_registry, quote_identifier
-from ibis.expr.types.core import unnamed
 
 
 class QueryContext:
@@ -199,7 +198,7 @@ def _needs_name(self, op):
             # This column has been given an explicitly different name
             return False
 
-        return op.name is not unnamed
+        return bool(op.name)
 
     def name(self, translated, name, force=True):
         return f'{translated} AS {quote_identifier(name, force=force)}'

ibis/backends/base/sql/registry/main.py

@@ -166,7 +166,7 @@ def table_column(translator, op):
 def exists_subquery(translator, op):
     ctx = translator.context
 
-    dummy = ir.literal(1).name(ir.core.unnamed)
+    dummy = ir.literal(1).name("")
 
     filtered = op.foreign_table.to_expr().filter(
         [pred.to_expr() for pred in op.predicates]

ibis/expr/operations/core.py

@@ -8,7 +8,7 @@
 import ibis.expr.rules as rlz
 from ibis.common.graph import Node as Traversable
 from ibis.common.grounds import Concrete
-from ibis.util import UnnamedMarker, deprecated
+from ibis.util import deprecated
 
 if TYPE_CHECKING:
     import ibis.expr.datatypes as dt
@@ -92,7 +92,7 @@ def to_expr(self):
 @public
 class Alias(Value):
     arg = rlz.any
-    name = rlz.instance_of((str, UnnamedMarker))
+    name = rlz.instance_of(str)
 
     output_shape = rlz.shape_like("arg")
     output_dtype = rlz.dtype_like("arg")

ibis/expr/schema.py

@@ -10,7 +10,7 @@
 from ibis.common.exceptions import IntegrityError
 from ibis.common.grounds import Concrete
 from ibis.common.validators import instance_of, tuple_of, validator
-from ibis.util import UnnamedMarker, indent
+from ibis.util import indent
 
 if TYPE_CHECKING:
     import pandas as pd
@@ -46,7 +46,7 @@ def datatype(arg, **kwargs):
 class Schema(Concrete):
     """An object for holding table schema information."""
 
-    names = tuple_of(instance_of((str, UnnamedMarker)))
+    names = tuple_of(instance_of(str))
     """A sequence of [`str`][str] indicating the name of each column."""
     types = tuple_of(datatype)
     """A sequence of [DataType][ibis.expr.datatypes.DataType] objects

ibis/expr/types/core.py

@@ -13,7 +13,7 @@
 from ibis.common.exceptions import IbisError, IbisTypeError, TranslationError
 from ibis.common.grounds import Immutable
 from ibis.config import _default_backend, options
-from ibis.util import UnnamedMarker, experimental
+from ibis.util import experimental
 
 if TYPE_CHECKING:
     import pyarrow as pa
@@ -381,9 +381,6 @@ def as_table(self) -> ir.Table:
         raise NotImplementedError(type(self))
 
 
-unnamed = UnnamedMarker()
-
-
 def _binop(
     op_class: type[ops.Binary], left: ir.Value, right: ir.Value
 ) -> ir.Value | NotImplemented:

ibis/util.py

@@ -89,10 +89,6 @@ def __repr__(self):
         return f"{self.__class__.__name__}({super().__repr__()})"
 
 
-class UnnamedMarker:
-    pass
-
-
 def guid() -> str:
     """Return a uuid4 hexadecimal value."""
     return uuid4().hex