chore: remove unnecessary argmax/argmin mapping

cpcloud · cpcloud · commit dbde452fa9b6 · 2024-11-03T03:59:02.000-05:00
diff --git a/ibis/backends/sql/compilers/pyspark.py b/ibis/backends/sql/compilers/pyspark.py
@@ -71,8 +71,6 @@ class PySparkCompiler(SQLGlotCompiler):
     }
 
     SIMPLE_OPS = {
-        ops.ArgMax: "max_by",
-        ops.ArgMin: "min_by",
         ops.ArrayDistinct: "array_distinct",
         ops.ArrayFlatten: "flatten",
         ops.ArrayIntersect: "array_intersect",
diff --git a/ibis/backends/sql/compilers/trino.py b/ibis/backends/sql/compilers/trino.py
@@ -65,8 +65,6 @@ class TrinoCompiler(SQLGlotCompiler):
 
     SIMPLE_OPS = {
         ops.Arbitrary: "any_value",
-        ops.ArgMax: "max_by",
-        ops.ArgMin: "min_by",
         ops.Pi: "pi",
         ops.E: "e",
         ops.RegexReplace: "regexp_replace",

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,6 @@ class PySparkCompiler(SQLGlotCompiler):`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`SIMPLE_OPS = {`
`74`		`- ops.ArgMax: "max_by",`
`75`		`- ops.ArgMin: "min_by",`
`76`	`74`	`ops.ArrayDistinct: "array_distinct",`
`77`	`75`	`ops.ArrayFlatten: "flatten",`
`78`	`76`	`ops.ArrayIntersect: "array_intersect",`