Skip to content

Commit d6e411b

Browse files
committed
refactor(api)!: align signatures of truncate_table method; name is positional-only; the rest are keyword-only
1 parent 98dc49f commit d6e411b

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

ibis/backends/clickhouse/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ def drop_database(self, name: str, /, *, force: bool = False) -> None:
575575
with self._safe_raw_sql(src):
576576
pass
577577

578-
def truncate_table(self, name: str, database: str | None = None) -> None:
578+
def truncate_table(self, name: str, /, *, database: str | None = None) -> None:
579579
ident = sg.table(name, db=database).sql(self.name)
580580
with self._safe_raw_sql(f"TRUNCATE TABLE {ident}"):
581581
pass

ibis/backends/datafusion/__init__.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -666,11 +666,7 @@ def create_table(
666666

667667
return self.table(name, database=database)
668668

669-
def truncate_table(
670-
self,
671-
name: str,
672-
database: str | None = None,
673-
):
669+
def truncate_table(self, name: str, /, *, database: str | None = None):
674670
"""Delete all rows from a table.
675671
676672
Parameters
@@ -679,7 +675,6 @@ def truncate_table(
679675
Table name
680676
database
681677
Database name
682-
683678
"""
684679
# datafusion doesn't support `TRUNCATE TABLE` so we use `DELETE FROM`
685680
#

ibis/backends/impala/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@ def drop_table(
836836
statement = ddl.DropTable(name, database=database, must_exist=not force)
837837
self._safe_exec_sql(statement)
838838

839-
def truncate_table(self, name: str, database: str | None = None) -> None:
839+
def truncate_table(self, name: str, /, *, database: str | None = None) -> None:
840840
"""Delete all rows from an existing table.
841841
842842
Parameters
@@ -845,7 +845,6 @@ def truncate_table(self, name: str, database: str | None = None) -> None:
845845
Table name
846846
database
847847
Database name
848-
849848
"""
850849
statement = ddl.TruncateTable(name, database=database)
851850
self._safe_exec_sql(statement)

ibis/backends/sql/__init__.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -454,11 +454,7 @@ def _build_insert_template(
454454
),
455455
).sql(self.dialect)
456456

457-
def truncate_table(
458-
self,
459-
name: str,
460-
database: str | None = None,
461-
) -> None:
457+
def truncate_table(self, name: str, /, *, database: str | None = None) -> None:
462458
"""Delete all rows from a table.
463459
464460
::: {.callout-note}

0 commit comments

Comments
 (0)