feat(oracle): implement mode aggregation

Author: cpcloud

ibis/backends/sql/compilers/oracle.py

@@ -57,7 +57,6 @@ class OracleCompiler(SQLGlotCompiler):
         ops.ArrayFlatten,
         ops.ArrayMap,
         ops.ArrayStringJoin,
-        ops.Mode,
         ops.MultiQuantile,
         ops.RegexSplit,
         ops.StringSplit,
@@ -89,6 +88,7 @@ class OracleCompiler(SQLGlotCompiler):
         ops.RPad: "rpad",
         ops.StringAscii: "ascii",
         ops.Strip: "trim",
+        ops.Mode: "stats_mode",
     }
 
     @staticmethod

ibis/backends/tests/test_aggregation.py

@@ -93,7 +93,6 @@ def mean_udf(s):
                     "pyspark",
                     "trino",
                     "druid",
-                    "oracle",
                     "flink",
                     "risingwave",
                     "exasol",
@@ -391,7 +390,6 @@ def mean_and_std(v):
                         "mssql",
                         "trino",
                         "druid",
-                        "oracle",
                         "exasol",
                         "flink",
                         "risingwave",

ibis/backends/tests/test_generic.py

@@ -906,20 +906,14 @@ def test_table_info_large(con):
             ],
             marks=[
                 pytest.mark.notimpl(
-                    [
-                        "clickhouse",
-                        "exasol",
-                        "impala",
-                        "pyspark",
-                        "risingwave",
-                    ],
+                    ["clickhouse", "exasol", "impala", "pyspark", "risingwave"],
                     raises=com.OperationNotDefinedError,
                     reason="mode is not supported",
                 ),
                 pytest.mark.notimpl(
                     ["oracle"],
-                    raises=com.OperationNotDefinedError,
-                    reason="Mode is not supported and ORA-02000: missing AS keyword",
+                    raises=OracleDatabaseError,
+                    reason="ORA-02000: missing AS keyword",
                 ),
                 pytest.mark.notimpl(
                     ["dask"],