refactor(dtypes): expose nbytes property for integer and floating point datatypes

Author: kszucs

ibis/backends/clickhouse/compiler/values.py

@@ -636,7 +636,7 @@ def _bit_agg(func):
     def _translate(op, **kw):
         arg = translate_val(op.arg, **kw)
         if not isinstance((type := op.arg.output_dtype), dt.UnsignedInteger):
-            nbits = type._nbytes * 8
+            nbits = type.nbytes * 8
             arg = f"reinterpretAsUInt{nbits}({arg})"
 
         if (where := op.where) is not None:

ibis/expr/datatypes/cast.py

@@ -90,15 +90,15 @@ def can_cast_to_differently_signed_integer_type(
 @castable.register(dt.SignedInteger, dt.SignedInteger)
 @castable.register(dt.UnsignedInteger, dt.UnsignedInteger)
 def can_cast_integers(source: dt.Integer, target: dt.Integer, **kwargs) -> bool:
-    return target._nbytes >= source._nbytes
+    return target.nbytes >= source.nbytes
 
 
 @castable.register(dt.Floating, dt.Floating)
 def can_cast_floats(
     source: dt.Floating, target: dt.Floating, upcast: bool = False, **kwargs
 ) -> bool:
     if upcast:
-        return target._nbytes >= source._nbytes
+        return target.nbytes >= source.nbytes
 
     # double -> float must be allowed because
     # float literals are inferred as doubles

ibis/expr/datatypes/core.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import numbers
+from abc import abstractmethod
 from typing import Any, Iterable, Mapping, NamedTuple
 
 import numpy as np
@@ -237,6 +238,11 @@ class Primitive(DataType, Singleton):
     """Values with known size."""
 
 
+@public
+class Variadic(DataType):
+    """Values with unknown size."""
+
+
 @public
 class Null(Primitive):
     """Null values."""
@@ -245,11 +251,6 @@ class Null(Primitive):
     column = ir.NullColumn
 
 
-@public
-class Variadic(DataType):
-    """Values with unknown size."""
-
-
 @public
 class Boolean(Primitive):
     """[`True`][True] or [`False`][False] values."""
@@ -279,11 +280,9 @@ class Integer(Primitive, Numeric):
     column = ir.IntegerColumn
 
     @property
-    def _nbytes(self) -> int:
+    @abstractmethod
+    def nbytes(self) -> int:
         """Return the number of bytes used to store values of this type."""
-        raise TypeError(
-            "Cannot determine the size in bytes of an abstract integer type."
-        )
 
 
 @public
@@ -366,7 +365,7 @@ def largest(self):
 
     @property
     def bounds(self):
-        exp = self._nbytes * 8 - 1
+        exp = self.nbytes * 8 - 1
         upper = (1 << exp) - 1
         return Bounds(lower=~upper, upper=upper)
 
@@ -382,7 +381,7 @@ def largest(self):
 
     @property
     def bounds(self):
-        exp = self._nbytes * 8 - 1
+        exp = self.nbytes * 8 - 1
         upper = 1 << exp
         return Bounds(lower=0, upper=upper)
 
@@ -400,87 +399,86 @@ def largest(self):
         return float64
 
     @property
-    def _nbytes(self) -> int:
-        raise TypeError(
-            "Cannot determine the size in bytes of an abstract floating point type."
-        )
+    @abstractmethod
+    def nbytes(self) -> int:  # pragma: no cover
+        ...
 
 
 @public
 class Int8(SignedInteger):
     """Signed 8-bit integers."""
 
-    _nbytes = 1
+    nbytes = 1
 
 
 @public
 class Int16(SignedInteger):
     """Signed 16-bit integers."""
 
-    _nbytes = 2
+    nbytes = 2
 
 
 @public
 class Int32(SignedInteger):
     """Signed 32-bit integers."""
 
-    _nbytes = 4
+    nbytes = 4
 
 
 @public
 class Int64(SignedInteger):
     """Signed 64-bit integers."""
 
-    _nbytes = 8
+    nbytes = 8
 
 
 @public
 class UInt8(UnsignedInteger):
     """Unsigned 8-bit integers."""
 
-    _nbytes = 1
+    nbytes = 1
 
 
 @public
 class UInt16(UnsignedInteger):
     """Unsigned 16-bit integers."""
 
-    _nbytes = 2
+    nbytes = 2
 
 
 @public
 class UInt32(UnsignedInteger):
     """Unsigned 32-bit integers."""
 
-    _nbytes = 4
+    nbytes = 4
 
 
 @public
 class UInt64(UnsignedInteger):
     """Unsigned 64-bit integers."""
 
-    _nbytes = 8
+    nbytes = 8
 
 
 @public
 class Float16(Floating):
     """16-bit floating point numbers."""
 
-    _nbytes = 2
+    nbytes = 2
 
 
 @public
 class Float32(Floating):
     """32-bit floating point numbers."""
 
-    _nbytes = 4
+    nbytes = 4
 
 
 @public
 class Float64(Floating):
     """64-bit floating point numbers."""
 
-    _nbytes = 8
+    nbytes = 8
 
 
 @public