Skip to content

Commit b1d7672

Browse files
krzysztof-kwittcpcloud
authored andcommitted
feat(datafusion): implement ops.StringAscii
1 parent 2fe3fc4 commit b1d7672

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

ibis/backends/datafusion/compiler.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,11 @@ def string_translate(op):
476476
return df.functions.translate(*map(translate, op.args))
477477

478478

479+
@translate.register(ops.StringAscii)
480+
def string_ascii(op):
481+
return df.functions.ascii(translate(op.arg))
482+
483+
479484
@translate.register(ops.RegexExtract)
480485
def regex_extract(op):
481486
arg = translate(op.arg)

ibis/backends/tests/test_string.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,7 @@ def test_string_col_is_unicode(alltypes, df):
361361
lambda t: t.string_col.ascii_str(),
362362
lambda t: t.string_col.map(ord).astype('int32'),
363363
id='ascii_str',
364-
marks=pytest.mark.notimpl(
365-
["datafusion", "polars"], raises=com.OperationNotDefinedError
366-
),
364+
marks=pytest.mark.notimpl(["polars"], raises=com.OperationNotDefinedError),
367365
),
368366
param(
369367
lambda t: t.string_col.length(),

0 commit comments

Comments
 (0)