Skip to content

Commit ae30920

Browse files
fix(deps): update dependency datafusion to v42 (#10304)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Phillip Cloud <[email protected]>
1 parent 9f6cf86 commit ae30920

File tree

9 files changed

+24
-18
lines changed

9 files changed

+24
-18
lines changed

ibis/backends/datafusion/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ def _get_schema_using_query(self, query: str) -> sch.Schema:
166166
this=table,
167167
kind="VIEW",
168168
expression=sg.parse_one(query, read=self.dialect),
169-
properties=sge.Properties(expressions=[sge.TemporaryProperty()]),
170169
)
171170

172171
with self._safe_raw_sql(src):
@@ -689,6 +688,9 @@ def truncate_table(
689688
with self._safe_raw_sql(sge.delete(ident)):
690689
pass
691690

691+
def _create_cached_table(self, name: str, expr: ir.Table) -> ir.Table:
692+
return self.create_table(name, expr, schema=expr.schema())
693+
692694

693695
@contextlib.contextmanager
694696
def _create_and_drop_memtable(_conn, table_name, tmp_name, overwrite):

ibis/backends/tests/test_aggregation.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1678,6 +1678,7 @@ def test_value_counts_on_expr(backend, alltypes, df):
16781678
backend.assert_frame_equal(result, expected)
16791679

16801680

1681+
@pytest.mark.xfail_version(datafusion=["datafusion==42"])
16811682
def test_group_by_expr(backend, con):
16821683
expr = (
16831684
ibis.memtable(

ibis/backends/tests/test_client.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,11 +294,16 @@ def test_create_table_from_schema(con, new_schema, temp_table):
294294
reason="temporary tables not implemented",
295295
raises=NotImplementedError,
296296
)
297-
@pytest.mark.never(
297+
@pytest.mark.notyet(
298298
["risingwave"],
299299
raises=com.UnsupportedOperationError,
300300
reason="Feature is not yet implemented: CREATE TEMPORARY TABLE",
301301
)
302+
@pytest.mark.notyet(
303+
["datafusion"],
304+
raises=Exception,
305+
reason="temp tables are not supported upstream in datafusion",
306+
)
302307
@pytest.mark.notimpl(
303308
["flink"],
304309
raises=com.IbisError,

ibis/backends/tests/test_generic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1068,7 +1068,7 @@ def test_int_scalar(alltypes):
10681068
assert isinstance(expr.execute(), int)
10691069

10701070

1071-
@pytest.mark.notimpl(["datafusion", "polars", "druid"])
1071+
@pytest.mark.notimpl(["polars", "druid"])
10721072
@pytest.mark.notyet(
10731073
["clickhouse"], reason="https://github.com/ClickHouse/ClickHouse/issues/6697"
10741074
)

ibis/backends/tests/test_map.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,6 @@ def test_map_construct_dict(con, keys, values):
555555
)
556556
@mark_notimpl_risingwave_hstore
557557
@mark_notyet_postgres
558-
@mark_notyet_datafusion
559558
def test_map_construct_array_column(con, alltypes, df):
560559
expr = ibis.map(ibis.array([alltypes.string_col]), ibis.array([alltypes.int_col]))
561560
result = con.execute(expr)

ibis/backends/tests/tpc/ds/test_queries.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1994,6 +1994,9 @@ def test_38(store_sales, catalog_sales, web_sales, date_dim, customer):
19941994

19951995

19961996
@tpc_test("ds")
1997+
@pytest.mark.notyet(
1998+
["datafusion"], reason="incorrect results", raises=AssertionError, strict=False
1999+
)
19972000
def test_39(inventory, item, warehouse, date_dim):
19982001
inv = (
19992002
inventory.join(item, [("inv_item_sk", "i_item_sk")])
@@ -3980,10 +3983,6 @@ def test_74(customer, store_sales, date_dim, web_sales):
39803983
return expr
39813984

39823985

3983-
@pytest.mark.notyet(
3984-
["datafusion"],
3985-
reason="Invalid argument error: RowConverter column schema mismatch, expected Int32 got Int64",
3986-
)
39873986
@tpc_test("ds")
39883987
def test_75(
39893988
catalog_sales,

poetry.lock

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ clickhouse-connect = { version = ">=0.5.23,<1", optional = true, extras = [
5555
"numpy",
5656
"pandas",
5757
] }
58-
datafusion = { version = ">=0.6,<42", optional = true }
58+
datafusion = { version = ">=0.6,<43", optional = true }
5959
db-dtypes = { version = ">=0.3,<2", optional = true }
6060
deltalake = { version = ">=0.9.0,<1", optional = true }
6161
duckdb = { version = ">=0.8.1,<1.2", optional = true }

requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)