refactor(api)!: align signatures of to_csv/to_csv_dir methods

Author: cpcloud

ibis/backends/__init__.py

@@ -518,6 +518,7 @@ def to_parquet_dir(
     def to_csv(
         self,
         expr: ir.Table,
+        /,
         path: str | Path,
         *,
         params: Mapping[ir.Scalar, Any] | None = None,
@@ -540,7 +541,6 @@ def to_csv(
             Additional keyword arguments passed to pyarrow.csv.CSVWriter
 
         https://arrow.apache.org/docs/python/generated/pyarrow.csv.CSVWriter.html
-
         """
         self._import_pyarrow()
         import pyarrow.csv as pcsv

ibis/backends/duckdb/__init__.py

@@ -1444,6 +1444,7 @@ def to_parquet(
     def to_csv(
         self,
         expr: ir.Table,
+        /,
         path: str | Path,
         *,
         params: Mapping[ir.Scalar, Any] | None = None,
@@ -1465,9 +1466,8 @@ def to_csv(
             Mapping of scalar parameter expressions to value.
         header
             Whether to write the column names as the first line of the CSV file.
-        **kwargs
+        kwargs
             DuckDB CSV writer arguments. https://duckdb.org/docs/data/csv/overview.html#parameters
-
         """
         self._run_pre_execute_hooks(expr)
         query = self.compile(expr, params=params)

ibis/expr/types/core.py

@@ -733,6 +733,7 @@ def to_parquet_dir(
     def to_csv(
         self,
         path: str | Path,
+        /,
         *,
         params: Mapping[ir.Scalar, Any] | None = None,
         **kwargs: Any,
@@ -753,7 +754,7 @@ def to_csv(
         **kwargs
             Additional keyword arguments passed to pyarrow.csv.CSVWriter
         """
-        self._find_backend(use_default=True).to_csv(self, path, **kwargs)
+        self._find_backend(use_default=True).to_csv(self, path, params=params, **kwargs)
 
     @experimental
     def to_delta(