refactor(api)!: expr argument of ibis.asc/ibis.desc is now positional-only; nulls_first is keyword-only

Author: cpcloud

ibis/expr/api.py

@@ -592,7 +592,7 @@ def _deferred_method_call(expr, method_name, **kwargs):
     return method(value)
 
 
-def desc(expr: ir.Column | str, nulls_first: bool = False) -> ir.Value:
+def desc(expr: ir.Column | str, /, *, nulls_first: bool = False) -> ir.Value:
     """Create a descending sort key from `expr` or column name.
 
     Parameters
@@ -633,7 +633,7 @@ def desc(expr: ir.Column | str, nulls_first: bool = False) -> ir.Value:
     return _deferred_method_call(expr, "desc", nulls_first=nulls_first)
 
 
-def asc(expr: ir.Column | str, nulls_first: bool = False) -> ir.Value:
+def asc(expr: ir.Column | str, /, *, nulls_first: bool = False) -> ir.Value:
     """Create a ascending sort key from `asc` or column name.
 
     Parameters

ibis/expr/types/generic.py

@@ -1237,8 +1237,8 @@ def __le__(self, other: Value) -> ir.BooleanValue:
     def __lt__(self, other: Value) -> ir.BooleanValue:
         return _binop(ops.Less, self, other)
 
-    def asc(self, nulls_first: bool = False) -> ir.Value:
-        """Sort an expression ascending.
+    def asc(self, *, nulls_first: bool = False) -> ir.Value:
+        """Sort an expression in ascending order.
 
         Parameters
         ----------
@@ -1284,8 +1284,8 @@ def asc(self, nulls_first: bool = False) -> ir.Value:
         """
         return ops.SortKey(self, ascending=True, nulls_first=nulls_first).to_expr()
 
-    def desc(self, nulls_first: bool = False) -> ir.Value:
-        """Sort an expression descending.
+    def desc(self, *, nulls_first: bool = False) -> ir.Value:
+        """Sort an expression in descending order.
 
         Parameters
         ----------