Skip to content

Commit 51afc13

Browse files
cpcloudjcrist
authored andcommitted
fix(pyspark): raise proper error when trying to generate sql
1 parent 946202b commit 51afc13

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

ibis/backends/pyspark/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -704,3 +704,6 @@ def _register_failure(self):
704704
f"Cannot infer appropriate read function for input, "
705705
f"please call one of {msg} directly"
706706
)
707+
708+
def _to_sql(self, expr: ir.Expr, **kwargs) -> str:
709+
raise NotImplementedError(f"Backend '{self.name}' backend doesn't support SQL")

ibis/backends/tests/test_generic.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -948,7 +948,9 @@ def test_memtable_construct(backend, con, monkeypatch):
948948
raises=NotImplementedError,
949949
reason="not a SQL backend",
950950
)
951-
@pytest.mark.notimpl(["pyspark"], raises=com.OperationNotDefinedError)
951+
@pytest.mark.notimpl(
952+
["pyspark"], reason="pyspark doesn't generate SQL", raises=NotImplementedError
953+
)
952954
@pytest.mark.notimpl(["druid"], reason="no sqlglot dialect", raises=ValueError)
953955
def test_many_subqueries(con, snapshot):
954956
def query(t, group_cols):

0 commit comments

Comments
 (0)