Skip to content

Commit 4a1c7c9

Browse files
cpcloudkszucs
authored andcommitted
refactor(snowflake): use unary instead of fixed_arity(..., 1)
1 parent 029499c commit 4a1c7c9

File tree

1 file changed

+17
-22
lines changed

1 file changed

+17
-22
lines changed

ibis/backends/snowflake/registry.py

Lines changed: 17 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,15 @@ def _extract_url_query(t, op):
9999
ops.JSONGetItem: fixed_arity(sa.func.get, 2),
100100
ops.StructField: fixed_arity(sa.func.get, 2),
101101
ops.StringFind: _string_find,
102-
ops.MapKeys: fixed_arity(sa.func.object_keys, 1),
102+
ops.MapKeys: unary(sa.func.object_keys),
103103
ops.BitwiseLeftShift: fixed_arity(sa.func.bitshiftleft, 2),
104104
ops.BitwiseRightShift: fixed_arity(sa.func.bitshiftright, 2),
105-
ops.Ln: fixed_arity(sa.func.ln, 1),
106-
ops.Log2: fixed_arity(lambda arg: sa.func.log(2, arg), 1),
107-
ops.Log10: fixed_arity(lambda arg: sa.func.log(10, arg), 1),
105+
ops.Ln: unary(sa.func.ln),
106+
ops.Log2: unary(lambda arg: sa.func.log(2, arg)),
107+
ops.Log10: unary(lambda arg: sa.func.log(10, arg)),
108108
ops.Log: fixed_arity(lambda arg, base: sa.func.log(base, arg), 2),
109-
ops.IsInf: fixed_arity(lambda arg: arg.in_((_SF_POS_INF, _SF_NEG_INF)), 1),
110-
ops.IsNan: fixed_arity(lambda arg: arg == _SF_NAN, 1),
109+
ops.IsInf: unary(lambda arg: arg.in_((_SF_POS_INF, _SF_NEG_INF))),
110+
ops.IsNan: unary(lambda arg: arg == _SF_NAN),
111111
ops.Literal: _literal,
112112
ops.Round: _round,
113113
ops.Modulus: fixed_arity(sa.func.mod, 2),
@@ -125,43 +125,38 @@ def _extract_url_query(t, op):
125125
# time and dates
126126
ops.TimeFromHMS: fixed_arity(sa.func.time_from_parts, 3),
127127
# columns
128-
ops.DayOfWeekName: fixed_arity(_day_of_week_name, 1),
129-
ops.ExtractProtocol: fixed_arity(
128+
ops.DayOfWeekName: unary(_day_of_week_name),
129+
ops.ExtractProtocol: unary(
130130
lambda arg: sa.func.nullif(
131131
sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "scheme")), ""
132-
),
133-
1,
132+
)
134133
),
135-
ops.ExtractAuthority: fixed_arity(
134+
ops.ExtractAuthority: unary(
136135
lambda arg: sa.func.concat_ws(
137136
":",
138137
sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "host")),
139138
sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "port")),
140-
),
141-
1,
139+
)
142140
),
143-
ops.ExtractFile: fixed_arity(
141+
ops.ExtractFile: unary(
144142
lambda arg: sa.func.concat_ws(
145143
"?",
146144
"/"
147145
+ sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "path")),
148146
sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "query")),
149-
),
150-
1,
147+
)
151148
),
152-
ops.ExtractPath: fixed_arity(
149+
ops.ExtractPath: unary(
153150
lambda arg: (
154151
"/" + sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "path"))
155-
),
156-
1,
152+
)
157153
),
158154
ops.ExtractQuery: _extract_url_query,
159-
ops.ExtractFragment: fixed_arity(
155+
ops.ExtractFragment: unary(
160156
lambda arg: sa.func.nullif(
161157
sa.func.as_varchar(sa.func.get(sa.func.parse_url(arg, 1), "fragment")),
162158
"",
163-
),
164-
1,
159+
)
165160
),
166161
# snowflake typeof only accepts VARIANT
167162
ops.TypeOf: unary(lambda arg: sa.func.typeof(sa.cast(arg, VARIANT))),

0 commit comments

Comments
 (0)