fix(athena): use exists instead of replace for create_database (#10767)

Author: cpcloud

ibis/backends/athena/__init__.py

@@ -449,15 +449,15 @@ def create_database(
         self, name: str, catalog: str | None = None, force: bool = False
     ) -> None:
         name = sg.table(name, catalog=catalog, quoted=self.compiler.quoted)
-        sql = sge.Create(this=name, kind="SCHEMA", replace=force)
+        sql = sge.Create(this=name, kind="SCHEMA", exists=force)
         with self._safe_raw_sql(sql, unload=False):
             pass
 
     def drop_database(
         self, name: str, catalog: str | None = None, force: bool = False
     ) -> None:
         name = sg.table(name, catalog=catalog, quoted=self.compiler.quoted)
-        sql = sge.Drop(this=name, kind="SCHEMA", replace=force)
+        sql = sge.Drop(this=name, kind="SCHEMA", exists=force)
         with self._safe_raw_sql(sql, unload=False):
             pass
 

ibis/backends/athena/tests/conftest.py

@@ -114,3 +114,8 @@ def batting(self):
     @property
     def awards_players(self):
         return self._remap_column_names("awards_players")
+
+
+@pytest.fixture(scope="session")
+def con(tmp_path_factory, data_dir, worker_id):
+    return TestConf.load_data(data_dir, tmp_path_factory, worker_id).connection

ibis/backends/athena/tests/test_client.py

@@ -0,0 +1,30 @@
+from __future__ import annotations
+
+import pytest
+
+from ibis.backends.tests.errors import PyAthenaOperationalError
+from ibis.util import gen_name
+
+
+def test_create_and_drop_database(con):
+    name = gen_name("db")
+
+    # create it
+    con.create_database(name)
+
+    # create it again with force=True (i.e., IF NOT EXISTS)
+    con.create_database(name, force=True)
+
+    # create it again (should fail)
+    with pytest.raises(PyAthenaOperationalError):
+        con.create_database(name)
+
+    # drop it
+    con.drop_database(name)
+
+    # drop it again with force=True (i.e., IF EXISTS)
+    con.drop_database(name, force=True)
+
+    # drop it again (should fail)
+    with pytest.raises(PyAthenaOperationalError):
+        con.drop_database(name)