Skip to content

Commit 33e1a31

Browse files
zhenzhongxugforsyth
authored andcommitted
fix(flink): add more test
1 parent 1b92b33 commit 33e1a31

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

.github/workflows/ibis-docs-lint.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,9 @@ jobs:
186186
- name: checkout
187187
uses: actions/checkout@v4
188188

189+
- name: install pyflink
190+
run: nix develop --ignore-environment --keep HOME -c pip install apache-flink
191+
189192
- name: run doctest
190193
# keep HOME because duckdb (which we use for doctests) wants to use
191194
# that for extensions
@@ -200,6 +203,21 @@ jobs:
200203
- name: check that all frozen computations were done before push
201204
run: git diff --exit-code --stat
202205

206+
- name: ls links 1
207+
run: ls /home/runner/work/ibis/ibis/docs/_output/backends/
208+
209+
- name: ls links 2
210+
run: ls /home/runner/work/ibis/ibis/docs/_output/
211+
212+
- name: ls links 3
213+
run: ls /home/runner/work/ibis/ibis/docs/
214+
215+
- name: support
216+
run: nix develop --ignore-environment -c python ./gen_matrix.py
217+
218+
- name: redirect links
219+
run: python ./gen_redirects.py
220+
203221
- name: verify internal links
204222
run: nix develop --ignore-environment '.#links' -c just checklinks --offline --no-progress
205223

gen_matrix.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def main():
4545
"docs", "backends", "raw_support_matrix.csv"
4646
).open(mode="w") as f:
4747
df.to_csv(f, index_label="FullOperation")
48+
print(f"CSV output path: {f.name}") # noqa: T201
4849

4950

5051
if __name__ == "__main__":

ibis/backends/flink/tests/test_ddl.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ def test_force_recreate_in_mem_table(
242242
tbl_properties=tbl_properties,
243243
)
244244
assert temp_table in con.list_tables()
245+
assert temp_table in con.list_views()
245246
if schema is not None:
246247
assert new_table.schema() == schema
247248

@@ -254,6 +255,7 @@ def test_force_recreate_in_mem_table(
254255
overwrite=True,
255256
)
256257
assert temp_table in con.list_tables()
258+
assert temp_table in con.list_views()
257259
if schema is not None:
258260
assert new_table.schema() == schema
259261

0 commit comments

Comments
 (0)