fix(sqlalchemy): use exec_driver_sql in view teardown

Author: cpcloud

ibis/backends/base/sql/alchemy/__init__.py

@@ -581,9 +581,7 @@ def _quote(self, name: str) -> str:
         return self.con.dialect.identifier_preparer.quote(name)
 
     def _get_temp_view_definition(
-        self,
-        name: str,
-        definition: sa.sql.compiler.Compiled,
+        self, name: str, definition: sa.sql.compiler.Compiled
     ) -> str:
         raise NotImplementedError(
             f"The {self.name} backend does not implement temporary view creation"
@@ -593,8 +591,8 @@ def _register_temp_view_cleanup(self, name: str, raw_name: str) -> None:
         query = f"DROP VIEW IF EXISTS {name}"
 
         def drop(self, raw_name: str, query: str):
-            with self.con.begin() as con:
-                con.execute(query)
+            with self.begin() as con:
+                con.exec_driver_sql(query)
             self._temp_views.discard(raw_name)
 
         atexit.register(drop, self, raw_name, query)

ibis/backends/duckdb/__init__.py

@@ -474,9 +474,7 @@ def _get_sqla_table(
             return super()._get_sqla_table(name, schema, **kwargs)
 
     def _get_temp_view_definition(
-        self,
-        name: str,
-        definition: sa.sql.compiler.Compiled,
+        self, name: str, definition: sa.sql.compiler.Compiled
     ) -> str:
         yield f"CREATE OR REPLACE TEMPORARY VIEW {name} AS {definition}"
 

ibis/backends/mssql/__init__.py

@@ -59,8 +59,6 @@ def _metadata(self, query):
                 yield column["name"], _type_from_result_set_info(column)
 
     def _get_temp_view_definition(
-        self,
-        name: str,
-        definition: sa.sql.compiler.Compiled,
+        self, name: str, definition: sa.sql.compiler.Compiled
     ) -> str:
         yield f"CREATE OR ALTER VIEW {name} AS {definition}"

ibis/backends/mysql/__init__.py

@@ -136,9 +136,7 @@ def _metadata(self, query: str) -> Iterable[tuple[str, dt.DataType]]:
             )
 
     def _get_temp_view_definition(
-        self,
-        name: str,
-        definition: sa.sql.compiler.Compiled,
+        self, name: str, definition: sa.sql.compiler.Compiled
     ) -> str:
         yield f"CREATE OR REPLACE VIEW {name} AS {definition}"
 

ibis/backends/postgres/__init__.py

@@ -176,7 +176,7 @@ def udf(
     def _metadata(self, query: str) -> Iterable[tuple[str, dt.DataType]]:
         raw_name = util.guid()
         name = self._quote(raw_name)
-        type_info_sql = f"""\
+        type_info_sql = """\
 SELECT
   attname,
   format_type(atttypid, atttypmod) AS type
@@ -194,8 +194,6 @@ def _metadata(self, query: str) -> Iterable[tuple[str, dt.DataType]]:
             con.execute(sa.text(f"DROP VIEW IF EXISTS {name}"))
 
     def _get_temp_view_definition(
-        self,
-        name: str,
-        definition: sa.sql.compiler.Compiled,
+        self, name: str, definition: sa.sql.compiler.Compiled
     ) -> str:
         yield f"CREATE OR REPLACE VIEW {name} AS {definition}"

ibis/backends/sqlite/__init__.py

@@ -256,9 +256,7 @@ def _get_schema_using_query(self, query: str) -> sch.Schema:
         return sch.Schema.from_tuples(self._metadata(query))
 
     def _get_temp_view_definition(
-        self,
-        name: str,
-        definition: sa.sql.compiler.Compiled,
+        self, name: str, definition: sa.sql.compiler.Compiled
     ) -> str:
         yield f"DROP VIEW IF EXISTS {name}"
         yield f"CREATE VIEW {name} AS {definition}"