Skip to content

Commit 22de2b5

Browse files
committed
refactor(api)!: align signatures of Backend.table method; name is positional-only; everything else is required-keyword
1 parent f5fae11 commit 22de2b5

File tree

8 files changed

+10
-9
lines changed

8 files changed

+10
-9
lines changed

ibis/backends/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,7 @@ def list_tables(
10201020

10211021
@abc.abstractmethod
10221022
def table(
1023-
self, name: str, database: tuple[str, str] | str | None = None
1023+
self, name: str, /, *, database: tuple[str, str] | str | None = None
10241024
) -> ir.Table:
10251025
"""Construct a table expression.
10261026

ibis/backends/athena/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def create_table(
209209

210210
return self.table(orig_table_ref.name, database=(catalog, db))
211211

212-
def table(self, name: str, database: str | None = None) -> ir.Table:
212+
def table(self, name: str, /, *, database: str | None = None) -> ir.Table:
213213
"""Construct a table expression.
214214
215215
Parameters
@@ -223,7 +223,6 @@ def table(self, name: str, database: str | None = None) -> ir.Table:
223223
-------
224224
Table
225225
Table expression
226-
227226
"""
228227
table_loc = self._to_sqlglot_table(database)
229228

ibis/backends/bigquery/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ def drop_database(
582582
def table(
583583
self,
584584
name: str,
585+
/,
586+
*,
585587
database: str | None = None,
586588
) -> ir.Table:
587589
table_loc = self._to_sqlglot_table(database)

ibis/backends/databricks/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def create_table(
199199

200200
return self.table(name, database=(catalog, database))
201201

202-
def table(self, name: str, database: str | None = None) -> ir.Table:
202+
def table(self, name: str, /, *, database: str | None = None) -> ir.Table:
203203
"""Construct a table expression.
204204
205205
Parameters

ibis/backends/duckdb/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def create_table(
235235

236236
return self.table(name, database=(catalog, database))
237237

238-
def table(self, name: str, database: str | None = None) -> ir.Table:
238+
def table(self, name: str, /, *, database: str | None = None) -> ir.Table:
239239
"""Construct a table expression.
240240
241241
Parameters

ibis/backends/flink/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@ def list_views(
247247
def table(
248248
self,
249249
name: str,
250+
/,
251+
*,
250252
database: str | None = None,
251253
catalog: str | None = None,
252254
) -> ir.Table:

ibis/backends/polars/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def version(self) -> str:
8686
def list_tables(self, like=None, database=None):
8787
return self._filter_with_like(list(self._tables.keys()), like)
8888

89-
def table(self, name: str, database: None = None) -> ir.Table:
89+
def table(self, name: str, /, *, database: None = None) -> ir.Table:
9090
if database is not None:
9191
raise com.IbisError(
9292
"Passing `database` to the Polars backend's `table()` method is not "

ibis/backends/sql/__init__.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@ def _fetch_from_cursor(self, cursor, schema: sch.Schema) -> pd.DataFrame:
6767
return df
6868

6969
def table(
70-
self,
71-
name: str,
72-
database: tuple[str, str] | str | None = None,
70+
self, name: str, /, *, database: tuple[str, str] | str | None = None
7371
) -> ir.Table:
7472
"""Construct a table expression.
7573

0 commit comments

Comments
 (0)